From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751454AbcELUeC (ORCPT ); Thu, 12 May 2016 16:34:02 -0400 Received: from mail.kernel.org ([198.145.29.136]:44040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbcELUeA (ORCPT ); Thu, 12 May 2016 16:34:00 -0400 Date: Thu, 12 May 2016 17:33:55 -0300 From: Arnaldo Carvalho de Melo To: David Ahern Cc: Arnaldo Carvalho de Melo , He Kuang , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given Message-ID: <20160512203355.GA11346@kernel.org> References: <1463042596-61703-1-git-send-email-hekuang@huawei.com> <1463042596-61703-4-git-send-email-hekuang@huawei.com> <20160512130925.GG20258@kernel.org> <5734E649.80505@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5734E649.80505@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, May 12, 2016 at 02:23:37PM -0600, David Ahern escreveu: > On 5/12/16 7:09 AM, Arnaldo Carvalho de Melo wrote: > > Em Thu, May 12, 2016 at 08:43:12AM +0000, He Kuang escreveu: > > > Symfs dir and buildid dir are two places that perf looks into for > > > symbols, currently, if symfs dir is given, buildid-cache is skipped. > > > In the cross-platform perf record/script scenario, we need vdsos in > > > buildid-cache dir and other libs in symfs dir at the same time. And > > > consider that the binaries indexed by buildid do not cause ambiguity, > > > this patch simply removes that logical. > > Makes perfect sense, David, do you have any concern? Can I have your > > Acked-by? > seems odd to me you want to look in the buildid-cache when a symfs is given. > The point of symfs was "go look for everything under here." > I believe dso__load is going to hit DSO_BINARY_TYPE__BUILD_ID_CACHE before > any of the others and there are probably cases where a stale cache entry > would be hit before a build tree entry (e.g., symfs). Stale cache entry? How'd that be? Its content based, i.e. if there is an entry for a given build id _anywhere_ why wouldn't we want to use it? > What about putting the build id cache under the symfs? so instead of > dropping the symfs check and it to the path for the build id cache. Well, the use case of look at both still looks sane to me, but maybe the way you suggest works for He, He? - Arnaldo