From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbcELVrI (ORCPT ); Thu, 12 May 2016 17:47:08 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:54266 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751102AbcELVrG (ORCPT ); Thu, 12 May 2016 17:47:06 -0400 Date: Thu, 12 May 2016 14:47:02 -0700 From: Stephen Boyd To: Maxime Ripard Cc: Priit Laes , Mike Turquette , David Airlie , Chen-Yu Tsai , Rob Herring , Daniel Vetter , Hans de Goede , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, dri-devel@lists.freedesktop.org, Boris Brezillon , Thomas Petazzoni , Alexander Kaplan , Laurent Pinchart Subject: Re: [linux-sunxi] Re: [PATCH v4 01/11] clk: sunxi: Add display and TCON0 clocks driver Message-ID: <20160512214702.GL3492@codeaurora.org> References: <1461590572-4027-2-git-send-email-maxime.ripard@free-electrons.com> <20160506223002.GE3492@codeaurora.org> <20160508200308.GF6167@lukather> <20160509223238.GW3492@codeaurora.org> <20160509223924.GX3492@codeaurora.org> <1462907459.9981.0.camel@plaes.org> <20160511221541.GG3492@codeaurora.org> <1463024360.16747.4.camel@plaes.org> <20160512065943.GX3733@lukather> <20160512083047.GY3733@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160512083047.GY3733@lukather> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12, Maxime Ripard wrote: > > diff --git a/drivers/clk/sunxi/clk-sun4i-display.c b/drivers/clk/sunxi/clk-sun4i-display.c > index 70803aa7028c..9780fac6d029 100644 > --- a/drivers/clk/sunxi/clk-sun4i-display.c > +++ b/drivers/clk/sunxi/clk-sun4i-display.c > @@ -128,8 +128,8 @@ static void __init sun4i_a10_display_init(struct device_node *node, > return; > } > > - ret = of_clk_parent_fill(node, parents, ARRAY_SIZE(parents)); > - if (ret != ARRAY_SIZE(parents)) { > + ret = of_clk_parent_fill(node, parents, data->parents); > + if (ret != data->parents) { > pr_err("%s: Could not retrieve the parents\n", clk_name); > goto unmap; > } Ah ok. Thanks for catching that thinko and sending a patch. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project