From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932131AbcEMLsy (ORCPT ); Fri, 13 May 2016 07:48:54 -0400 Received: from mail.kernel.org ([198.145.29.136]:57200 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932067AbcEMLsx (ORCPT ); Fri, 13 May 2016 07:48:53 -0400 Date: Fri, 13 May 2016 08:48:48 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen Subject: Re: [PATCH 1/3] perf diff: Fix indentation of stalled backend cycle Message-ID: <20160513114848.GD11346@kernel.org> References: <1463119263-5569-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463119263-5569-1-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, May 13, 2016 at 03:01:01PM +0900, Namhyung Kim escreveu: > The commit 140aeadc1fb5 ("perf stat: Abstract stat metrics printing") > changed way to print shadow metrics, but it missed to update the width > of stalled backend cycles event to 7.2% like others. This resulted in > misaligned output like below: Thanks for pointing out the cset that introduced the problem, helps in reviewing! Next time please consider adding it right before your Signed-off-by line as: Fixes: 140aeadc1fb5 ("perf stat: Abstract stat metrics printing") Thanks! - Arnaldo > Performance counter stats for 'pwd': > > 0.638313 task-clock (msec) # 0.567 CPUs utilized > 0 context-switches # 0.000 K/sec > 0 cpu-migrations # 0.000 K/sec > 54 page-faults # 0.085 M/sec > 885,600 cycles # 1.387 GHz > 558,438 stalled-cycles-frontend # 63.06% frontend cycles idle > 431,355 stalled-cycles-backend # 48.71% backend cycles idle > 674,956 instructions # 0.76 insn per cycle > # 0.83 stalled cycles per insn > 130,380 branches # 204.257 M/sec > branch-misses > > 0.001125426 seconds time elapsed > > Cc: Andi Kleen > Signed-off-by: Namhyung Kim > --- > tools/perf/util/stat-shadow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c > index fdb71961143e..61200fcac5ef 100644 > --- a/tools/perf/util/stat-shadow.c > +++ b/tools/perf/util/stat-shadow.c > @@ -188,7 +188,7 @@ static void print_stalled_cycles_backend(int cpu, > > color = get_ratio_color(GRC_STALLED_CYCLES_BE, ratio); > > - out->print_metric(out->ctx, color, "%6.2f%%", "backend cycles idle", ratio); > + out->print_metric(out->ctx, color, "%7.2f%%", "backend cycles idle", ratio); > } > > static void print_branch_misses(int cpu, > -- > 2.8.2