From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753068AbcEMND4 (ORCPT ); Fri, 13 May 2016 09:03:56 -0400 Received: from mail.kernel.org ([198.145.29.136]:34493 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750907AbcEMNDz (ORCPT ); Fri, 13 May 2016 09:03:55 -0400 Date: Fri, 13 May 2016 10:03:39 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: arnaldo.melo@gmail.com, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo , Peter Zijlstra , Zefan Li , pi3orama@163.com Subject: Re: [PATCH 01/17] perf tools: Extract __perf_evlist__mmap_read() Message-ID: <20160513130339.GG11346@kernel.org> References: <1463126174-119290-1-git-send-email-wangnan0@huawei.com> <1463126174-119290-2-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463126174-119290-2-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, May 13, 2016 at 07:55:58AM +0000, Wang Nan escreveu: > Extract event reader to __perf_evlist__mmap_read(). Future commit will > feed it with manually computed 'head' and 'old' pointers. why not use the perf_mmap__read() directly then? - Arnaldo > Signed-off-by: Wang Nan > Cc: Arnaldo Carvalho de Melo > Cc: Peter Zijlstra > Cc: Zefan Li > Cc: pi3orama@163.com > --- > tools/perf/util/evlist.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index c4bfe11..5e86972 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -749,6 +749,13 @@ broken_event: > return event; > } > > +static union perf_event * > +__perf_evlist__mmap_read(struct perf_mmap *md, bool overwrite, u64 head, > + u64 old, u64 *prev) > +{ > + return perf_mmap__read(md, overwrite, old, head, prev); > +} > + > union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx) > { > struct perf_mmap *md = &evlist->mmap[idx]; > @@ -763,7 +770,8 @@ union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx) > > head = perf_mmap__read_head(md); > > - return perf_mmap__read(md, evlist->overwrite, old, head, &md->prev); > + return __perf_evlist__mmap_read(md, evlist->overwrite, head, > + old, &md->prev); > } > > union perf_event * > -- > 1.8.3.4