From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932214AbcEMOBH (ORCPT ); Fri, 13 May 2016 10:01:07 -0400 Received: from one.firstfloor.org ([193.170.194.197]:54755 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536AbcEMOBE (ORCPT ); Fri, 13 May 2016 10:01:04 -0400 Date: Fri, 13 May 2016 07:00:55 -0700 From: Andi Kleen To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , Andi Kleen Subject: Re: [PATCH 1/3] perf diff: Fix indentation of stalled backend cycle Message-ID: <20160513140055.GI13997@two.firstfloor.org> References: <1463119263-5569-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463119263-5569-1-git-send-email-namhyung@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2016 at 03:01:01PM +0900, Namhyung Kim wrote: > The commit 140aeadc1fb5 ("perf stat: Abstract stat metrics printing") > changed way to print shadow metrics, but it missed to update the width > of stalled backend cycles event to 7.2% like others. This resulted in > misaligned output like below: Thanks. My preferred action would be actually kill stalled-cycles-frontend/backend. I don't know any CPU where it is accurate. TopDown is much better. But as long as it is kept it is better to align it right. -Andi