From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932555AbcEMVsU (ORCPT ); Fri, 13 May 2016 17:48:20 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35473 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932529AbcEMVsS (ORCPT ); Fri, 13 May 2016 17:48:18 -0400 Date: Fri, 13 May 2016 14:48:15 -0700 From: Brian Norris To: Doug Anderson Cc: Heiko Stuebner , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , Shawn Lin , Brian Norris Subject: Re: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399 Message-ID: <20160513214815.GA109473@google.com> References: <1463092552-60696-1-git-send-email-briannorris@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 13, 2016 at 02:42:06PM -0700, Doug Anderson wrote: > On Thu, May 12, 2016 at 3:35 PM, Brian Norris wrote: > > + emmc_phy: phy@f780 { > > + compatible = "rockchip,rk3399-emmc-phy"; > > + reg = <0xf780 0x20>; > > This is slightly wrong. It should be: > > reg = <0xf780 0x24>; > > The status register is at an offset of 0x20 and is 4 bytes big, so we > need room for it. Fixed. > After that is fixed, feel free to add my Reviewed-by tag. Done. Thanks for the review. Brian