From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753710AbcENCjh (ORCPT <rfc822;w@1wt.eu>);
	Fri, 13 May 2016 22:39:37 -0400
Received: from mail-pf0-f195.google.com ([209.85.192.195]:34417 "EHLO
	mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753527AbcENCjg (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 13 May 2016 22:39:36 -0400
Date: Sat, 14 May 2016 12:37:07 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] zram: introduce per-device debug_stat sysfs node
Message-ID: <20160514033707.GA15615@swordfish>
References: <20160511134553.12655-1-sergey.senozhatsky@gmail.com>
 <20160512234143.GA27204@bbox>
 <20160513010929.GA615@swordfish>
 <20160513062303.GA21204@bbox>
 <20160513065805.GB615@swordfish>
 <20160513070553.GC615@swordfish>
 <20160513072006.GA21484@bbox>
 <20160513080643.GE615@swordfish>
 <20160513230546.GA26763@bbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160513230546.GA26763@bbox>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Minchan,

On (05/14/16 08:05), Minchan Kim wrote:
[..]
> > recompress:
> > 	compress
> > 	handle = zs_malloc FAST PATH
> > 
> > 	if (!handle) {
> > 		release stream
> > 		handle = zs_malloc SLOW PATH
> > 
> > 		<< my patch accounts SLOW PATH here >>
> > 
> > 		if (handle) {
> > 			num_recompress++  << NEW version accounts it here, only it was OK >>
> > 			goto recompress;
> > 		}
> > 
> > 		goto err;    << SLOW PATH is not accounted if SLOW PATH was unsuccessful
> > 	}
> > 
> 
> I got your point. You want to account every slow path and change
> the naming from num_recompress to something to show that slow path.

yes :)

> Sorry for catching your point too late. And I absolutely agree with you.
> I want to name it with 'writestall' like MM's allocstall. :)

no problem. 'writestall' is really good, that's the word I was looking
for.

> Now I saw you sent new version but I like your suggestion more.
> 
> I will send new verion by hand :)
> Thanks for the arguing. It was worth!

oh, thanks!

	-ss