* [PATCH] tools: testing: define the _GNU_SOURCE macro
@ 2016-05-13 12:05 Muhammad Falak R Wani
2016-05-16 13:27 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Muhammad Falak R Wani @ 2016-05-13 12:05 UTC (permalink / raw)
To: Shuah Khan; +Cc: Prarit Bhargava, linux-kselftest, linux-kernel
Add the macro _GNU_SOURCE, so that compilation does not terminate.
Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
---
tools/testing/selftests/intel_pstate/run.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
index bdaf37e..7868c10 100755
--- a/tools/testing/selftests/intel_pstate/run.sh
+++ b/tools/testing/selftests/intel_pstate/run.sh
@@ -32,7 +32,7 @@ EVALUATE_ONLY=0
max_cpus=$(($(nproc)-1))
# compile programs
-gcc -o aperf aperf.c -lm
+gcc aperf.c -Wall -D_GNU_SOURCE -o aperf -lm
[ $? -ne 0 ] && echo "Problem compiling aperf.c." && exit 1
gcc -o msr msr.c -lm
[ $? -ne 0 ] && echo "Problem compiling msr.c." && exit 1
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tools: testing: define the _GNU_SOURCE macro
2016-05-13 12:05 [PATCH] tools: testing: define the _GNU_SOURCE macro Muhammad Falak R Wani
@ 2016-05-16 13:27 ` Shuah Khan
2016-05-16 14:02 ` Muhammad Falak R Wani
0 siblings, 1 reply; 4+ messages in thread
From: Shuah Khan @ 2016-05-16 13:27 UTC (permalink / raw)
To: Muhammad Falak R Wani
Cc: Prarit Bhargava, linux-kselftest, linux-kernel, Shuah Khan
On 05/13/2016 06:05 AM, Muhammad Falak R Wani wrote:
> Add the macro _GNU_SOURCE, so that compilation does not terminate.
What error are you seeing? Could you please send the compilation
error log.
thanks,
-- Shuah
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> ---
> tools/testing/selftests/intel_pstate/run.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
> index bdaf37e..7868c10 100755
> --- a/tools/testing/selftests/intel_pstate/run.sh
> +++ b/tools/testing/selftests/intel_pstate/run.sh
> @@ -32,7 +32,7 @@ EVALUATE_ONLY=0
> max_cpus=$(($(nproc)-1))
>
> # compile programs
> -gcc -o aperf aperf.c -lm
> +gcc aperf.c -Wall -D_GNU_SOURCE -o aperf -lm
> [ $? -ne 0 ] && echo "Problem compiling aperf.c." && exit 1
> gcc -o msr msr.c -lm
> [ $? -ne 0 ] && echo "Problem compiling msr.c." && exit 1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools: testing: define the _GNU_SOURCE macro
2016-05-16 13:27 ` Shuah Khan
@ 2016-05-16 14:02 ` Muhammad Falak R Wani
2016-05-16 16:14 ` Shuah Khan
0 siblings, 1 reply; 4+ messages in thread
From: Muhammad Falak R Wani @ 2016-05-16 14:02 UTC (permalink / raw)
To: Shuah Khan; +Cc: Prarit Bhargava, linux-kselftest, linux-kernel
On Mon, May 16, 2016 at 07:27:25AM -0600, Shuah Khan wrote:
> On 05/13/2016 06:05 AM, Muhammad Falak R Wani wrote:
> > Add the macro _GNU_SOURCE, so that compilation does not terminate.
>
> What error are you seeing? Could you please send the compilation
> error log.
>
> thanks,
> -- Shuah
> >
> > Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
> > ---
> > tools/testing/selftests/intel_pstate/run.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
> > index bdaf37e..7868c10 100755
> > --- a/tools/testing/selftests/intel_pstate/run.sh
> > +++ b/tools/testing/selftests/intel_pstate/run.sh
> > @@ -32,7 +32,7 @@ EVALUATE_ONLY=0
> > max_cpus=$(($(nproc)-1))
> >
> > # compile programs
> > -gcc -o aperf aperf.c -lm
> > +gcc aperf.c -Wall -D_GNU_SOURCE -o aperf -lm
> > [ $? -ne 0 ] && echo "Problem compiling aperf.c." && exit 1
> > gcc -o msr msr.c -lm
> > [ $? -ne 0 ] && echo "Problem compiling msr.c." && exit 1
> >
>
When I try to run "run.sh", I get the following linker error
------
mfrw@kp:~/kp/tools/testing/selftests/intel_pstate$ ./run.sh
/tmp/ccVLsFVk.o: In function `main':
aperf.c:(.text+0x12e): undefined reference to `CPU_ZERO'
aperf.c:(.text+0x14a): undefined reference to `CPU_SET'
collect2: error: ld returned 1 exit status
Problem compiling aperf.c.
------
The root cause of the problem is, we haven't defined a macro
_GNU_SOURCE, which is necessary for CPU_ZERO, CPU_SET.
After adding the appropriate macro, it compiles without
any error.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tools: testing: define the _GNU_SOURCE macro
2016-05-16 14:02 ` Muhammad Falak R Wani
@ 2016-05-16 16:14 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2016-05-16 16:14 UTC (permalink / raw)
To: Muhammad Falak R Wani; +Cc: Prarit Bhargava, linux-kselftest, linux-kernel
On 05/16/2016 08:02 AM, Muhammad Falak R Wani wrote:
> On Mon, May 16, 2016 at 07:27:25AM -0600, Shuah Khan wrote:
>> On 05/13/2016 06:05 AM, Muhammad Falak R Wani wrote:
>>> Add the macro _GNU_SOURCE, so that compilation does not terminate.
>>
>> What error are you seeing? Could you please send the compilation
>> error log.
>>
>> thanks,
>> -- Shuah
Applied to linux-kselftest next fgor 4.7-rc1 with fixed up changelog
to include why the change is needed.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-16 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-13 12:05 [PATCH] tools: testing: define the _GNU_SOURCE macro Muhammad Falak R Wani
2016-05-16 13:27 ` Shuah Khan
2016-05-16 14:02 ` Muhammad Falak R Wani
2016-05-16 16:14 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox