From: Eric Engestrom <eric.engestrom@imgtec.com>
To: Muhammad Falak R Wani <falakreyaz@gmail.com>
Cc: "David Airlie" <airlied@linux.ie>,
"Nils Wallménius" <nils.wallmenius@gmail.com>,
"Jammy Zhou" <Jammy.Zhou@amd.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Rex Zhu" <Rex.Zhu@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size.
Date: Mon, 16 May 2016 16:53:50 +0100 [thread overview]
Message-ID: <20160516155350.GQ7910@imgtec.com> (raw)
In-Reply-To: <1463161029-7490-1-git-send-email-falakreyaz@gmail.com>
On Fri, May 13, 2016 at 11:06:40PM +0530, Muhammad Falak R Wani wrote:
> It is preferred to use ARRAY_SIZE() for size calculation, instead
> using sizeof(array)/sizeof(*array). It makes the code more readable.
>
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Thanks, and sorry about before, if I made you feel like you made
a "childish mistake". As Dan said, this is mostly a question of
style: your code was right, it just had an unnecessary bit.
I hope I didn't give you a bad impression of the community, most
people around here have better manners than I :P
Cheers
next prev parent reply other threads:[~2016-05-16 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 17:36 [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size Muhammad Falak R Wani
2016-05-14 20:00 ` Christian König
2016-05-16 15:53 ` Eric Engestrom [this message]
2016-05-17 6:28 ` Muhammad Falak R Wani
2016-05-16 16:18 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160516155350.GQ7910@imgtec.com \
--to=eric.engestrom@imgtec.com \
--cc=Jammy.Zhou@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=falakreyaz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nils.wallmenius@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).