From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754579AbcEPTTb (ORCPT ); Mon, 16 May 2016 15:19:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:39840 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754425AbcEPTTa (ORCPT ); Mon, 16 May 2016 15:19:30 -0400 Date: Mon, 16 May 2016 21:19:18 +0200 From: Borislav Petkov To: Steven Rostedt Cc: Namhyung Kim , Masami Hiramatsu , LKML , Ingo Molnar , x86@kernel.org, "H.J. Lu" Subject: Re: [PATCH] ftrace/x86: Fix function graph tracer reset path Message-ID: <20160516191918.GC16265@pd.tnic> References: <1463147623-2575-1-git-send-email-namhyung@kernel.org> <20160515094141.0cff3ee44f1f0fa101b98b02@kernel.org> <20160515130652.GA7745@danjae.aot.lge.com> <20160516175614.53e0ceed3ec0880526fa1799@kernel.org> <20160516123250.GA16239@danjae.aot.lge.com> <20160516095833.08478147@gandalf.local.home> <20160516142453.GB16239@danjae.aot.lge.com> <20160516190359.GB16265@pd.tnic> <20160516151357.73fca76a@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160516151357.73fca76a@gandalf.local.home> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2016 at 03:13:57PM -0400, Steven Rostedt wrote: > I actually thought about this first, but I thought it rather a hack > (although one could argue all of function tracing is a hack ;-) ... I was about to say... > But as the "weak" call was used to fix one location, why not use > it here too. Being consistent, and also making sure all calls to > ftrace_stub do the same. Btw, arch_static_branch_jump() spells that 5-byte JMP too and not until too long ago we had it in static_cpu_has()... I guess after spending some time with the kernel, one can't really differentiate hacks from proper design anymore. :-P -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --