From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754169AbcEQBC0 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 May 2016 21:02:26 -0400
Received: from LGEAMRELO13.lge.com ([156.147.23.53]:56123 "EHLO
	lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752800AbcEQBCZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 May 2016 21:02:25 -0400
X-Original-SENDERIP: 156.147.1.126
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 165.244.98.150
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 10.177.223.161
X-Original-MAILFROM: minchan@kernel.org
Date: Tue, 17 May 2016 10:02:22 +0900
From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v5 07/12] zsmalloc: factor page chain functionality out
Message-ID: <20160517010222.GA31335@bbox>
References: <1462760433-32357-1-git-send-email-minchan@kernel.org>
 <1462760433-32357-8-git-send-email-minchan@kernel.org>
 <20160516021420.GC504@swordfish>
MIME-Version: 1.0
In-Reply-To: <20160516021420.GC504@swordfish>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/05/17 10:02:20,
	Serialize by Router on LGEKRMHUB08/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/05/17 10:02:20,
	Serialize complete at 2016/05/17 10:02:20
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 16, 2016 at 11:14:20AM +0900, Sergey Senozhatsky wrote:
> On (05/09/16 11:20), Minchan Kim wrote:
> > For page migration, we need to create page chain of zspage dynamically
> > so this patch factors it out from alloc_zspage.
> > 
> > Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> > Signed-off-by: Minchan Kim <minchan@kernel.org>
> 
> Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Thanks!

> 
> [..]
> > +		page = alloc_page(flags);
> > +		if (!page) {
> > +			while (--i >= 0)
> > +				__free_page(pages[i]);
> 
> 				put_page() ?
> 
> a minor nit, put_page() here probably will be in alignment
> with __free_zspage(), which does put_page().

Normally, we use put_page in case that someone can grab a referece of
the page so we cannot free the page. Otherwise, alloc_page and
__free_page is more straight to me code readability POV.

> 
> 	-ss
> 
> > +			return NULL;
> > +		}
> > +		pages[i] = page;
> >  	}
> >  
> > +	create_page_chain(pages, class->pages_per_zspage);
> > +	first_page = pages[0];
> > +	init_zspage(class, first_page);
> > +
> >  	return first_page;
> >  }