From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932867AbcEQBam (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 May 2016 21:30:42 -0400
Received: from mail-pa0-f67.google.com ([209.85.220.67]:33446 "EHLO
	mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932581AbcEQBai (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 May 2016 21:30:38 -0400
Date: Tue, 17 May 2016 10:30:09 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Rik van Riel <riel@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, Mel Gorman <mgorman@suse.de>,
        Hugh Dickins <hughd@google.com>, Rafael Aquini <aquini@redhat.com>,
        virtualization@lists.linux-foundation.org,
        Jonathan Corbet <corbet@lwn.net>,
        John Einar Reitan <john.reitan@foss.arm.com>,
        dri-devel@lists.freedesktop.org,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Gioh Kim <gi-oh.kim@profitbricks.com>
Subject: Re: [PATCH v5 02/12] mm: migrate: support non-lru movable page
 migration
Message-ID: <20160517013009.GB497@swordfish>
References: <1462760433-32357-1-git-send-email-minchan@kernel.org>
 <1462760433-32357-3-git-send-email-minchan@kernel.org>
 <20160516071751.GA32079@swordfish>
 <20160517011850.GD31335@bbox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160517011850.GD31335@bbox>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (05/17/16 10:18), Minchan Kim wrote:
[..]
> > >  #ifdef CONFIG_MIGRATION
> > >  
> > > +extern int PageMovable(struct page *page);
> > > +extern void __SetPageMovable(struct page *page, struct address_space *mapping);
> > > +extern void __ClearPageMovable(struct page *page);
> > >  extern void putback_movable_pages(struct list_head *l);
> > >  extern int migrate_page(struct address_space *,
> > >  			struct page *, struct page *, enum migrate_mode);
> > >  extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free,
> > >  		unsigned long private, enum migrate_mode mode, int reason);
> > > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode);
> > > +extern void putback_movable_page(struct page *page);
> > >  
> > >  extern int migrate_prep(void);
> > >  extern int migrate_prep_local(void);
> > 
> > given that some of Movable users can be built as modules, shouldn't
> > at least some of those symbols be exported via EXPORT_SYMBOL?
> 
> Those functions aim for VM compaction so driver shouldn't use it.
> Only driver should be aware of are __SetPageMovable and __CleraPageMovable.
> I will export them.
> 

and PageMovable(), probably?

zsmalloc():

	VM_BUG_ON_PAGE(!PageMovable(page), page);


> Thanks for the review, Sergey!

no prob! sorry, I'm a bit slow and late here.

	-ss