From: Greg KH <gregkh@linuxfoundation.org>
To: Amit Ghadge <amitg.b14@gmail.com>
Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue
Date: Mon, 16 May 2016 20:34:55 -0700 [thread overview]
Message-ID: <20160517033455.GA30241@kroah.com> (raw)
In-Reply-To: <20160517032555.GA9789@localhost.localdomain>
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Tue, May 17, 2016 at 08:55:56AM +0530, Amit Ghadge wrote:
> I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message,
>
> "drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'"
>
> This patch reduced the warning message.
Why didn't you put that information in the changelog area?
Please do so.
greg k-h
next prev parent reply other threads:[~2016-05-17 3:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 17:34 [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Amit Ghadge
2016-05-16 18:19 ` Greg KH
2016-05-17 3:25 ` Amit Ghadge
2016-05-17 3:34 ` Greg KH [this message]
2016-05-17 4:01 ` Amit Ghadge
2016-05-17 13:47 ` Greg KH
2016-05-18 1:29 ` Amit Ghadge
2016-06-18 3:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517033455.GA30241@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abbotti@mev.co.uk \
--cc=amitg.b14@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox