From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbcEQDe5 (ORCPT ); Mon, 16 May 2016 23:34:57 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36739 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751664AbcEQDe4 (ORCPT ); Mon, 16 May 2016 23:34:56 -0400 Date: Mon, 16 May 2016 20:34:55 -0700 From: Greg KH To: Amit Ghadge Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Message-ID: <20160517033455.GA30241@kroah.com> References: <1463420071-4460-1-git-send-email-amitg.b14@gmail.com> <20160516181905.GA12970@kroah.com> <20160517032555.GA9789@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160517032555.GA9789@localhost.localdomain> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Tue, May 17, 2016 at 08:55:56AM +0530, Amit Ghadge wrote: > I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message, > > "drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned'" > > This patch reduced the warning message. Why didn't you put that information in the changelog area? Please do so. greg k-h