From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751065AbcEQECS (ORCPT ); Tue, 17 May 2016 00:02:18 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34692 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbcEQECR (ORCPT ); Tue, 17 May 2016 00:02:17 -0400 Date: Tue, 17 May 2016 09:31:56 +0530 From: Amit Ghadge To: Greg KH Cc: abbotti@mev.co.uk, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: comedi: quatech_daqp_cs.c: fixed a warning issue Message-ID: <20160517040036.GA9991@localhost.localdomain> References: <1463420071-4460-1-git-send-email-amitg.b14@gmail.com> <20160516181905.GA12970@kroah.com> <20160517032555.GA9789@localhost.localdomain> <20160517033455.GA30241@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160517033455.GA30241@kroah.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Greg KH, I make patch same like other, I'm new and I nerver see changelog in other patches. Where to add changelog? I followed you are tutorial. Thanks, Amit Ghadge On Mon, May 16, 2016 at 08:34:55PM -0700, Greg KH wrote: > > A: No. > Q: Should I include quotations after my reply? > > http://daringfireball.net/2007/07/on_top > > On Tue, May 17, 2016 at 08:55:56AM +0530, Amit Ghadge wrote: > > I check with "./scripts/checkpatch.pl --file --terse drivers/staging/comedi/drivers/quatech_daqp_cs.c" and show the warning message, > > > > drivers/staging/comedi/drivers/quatech_daqp_cs.c:646: WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > > > This patch reduced the warning message. > > Why didn't you put that information in the changelog area? > > Please do so. > > greg k-h