From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754760AbcEQG2n (ORCPT ); Tue, 17 May 2016 02:28:43 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34823 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754465AbcEQG2e (ORCPT ); Tue, 17 May 2016 02:28:34 -0400 Date: Tue, 17 May 2016 11:58:23 +0530 From: Muhammad Falak R Wani To: Eric Engestrom Cc: David Airlie , Nils =?iso-8859-1?Q?Wallm=E9nius?= , Jammy Zhou , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Rex Zhu , Christian =?iso-8859-1?Q?K=F6nig?= , Dan Carpenter Subject: Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate array size. Message-ID: <20160517062823.GA3328@kp> References: <1463161029-7490-1-git-send-email-falakreyaz@gmail.com> <20160516155350.GQ7910@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160516155350.GQ7910@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2016 at 04:53:50PM +0100, Eric Engestrom wrote: > On Fri, May 13, 2016 at 11:06:40PM +0530, Muhammad Falak R Wani wrote: > > It is preferred to use ARRAY_SIZE() for size calculation, instead > > using sizeof(array)/sizeof(*array). It makes the code more readable. > > > > Signed-off-by: Muhammad Falak R Wani > > Reviewed-by: Eric Engestrom > > Thanks, and sorry about before, if I made you feel like you made > a "childish mistake". As Dan said, this is mostly a question of > style: your code was right, it just had an unnecessary bit. > > I hope I didn't give you a bad impression of the community, most > people around here have better manners than I :P > > Cheers Thank you for such a nice gesture. No, I didn't get any bad impression. Infact people learn like this. Thank you guys :)