From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754619AbcEQG2f (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 May 2016 02:28:35 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:39382 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754399AbcEQG2d (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 May 2016 02:28:33 -0400
Date: Tue, 17 May 2016 07:28:29 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Daniel Axtens <dja@axtens.net>, linux-fsdevel@vger.kernel.org,
        linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        mpe@ellerman.id.au, mszeredi@redhat.com, dchinner@redhat.com
Subject: Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"
 breaking Docker
Message-ID: <20160517062829.GG14480@ZenIV.linux.org.uk>
References: <87d1ombix6.fsf@gamma.ozlabs.ibm.com>
 <20160516130727.GA26411@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160516130727.GA26411@redhat.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 16, 2016 at 09:07:27AM -0400, Vivek Goyal wrote:
> So it became clear that we need a check at mount time to make sure
> d_type is supported otherwise error out. This will require users to
> do mkfs.xfs with ftype=1 to make progress.
> 
> I think new defaults for mkfs.xfs are such that ftype=1 is set. I am
> not sure which version that change was made in.

Dumb question - can we end up with empty workdir at that point?  Because
if we do, the check would appear to return a false negative, no matter
what fs supports...