From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754663AbcEQIjd (ORCPT ); Tue, 17 May 2016 04:39:33 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34951 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752069AbcEQIja (ORCPT ); Tue, 17 May 2016 04:39:30 -0400 Date: Tue, 17 May 2016 10:39:24 +0200 From: Ingo Molnar To: Zhao Lei Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , KOSAKI Motohiro Subject: Re: [PATCH v2 0/3] cpuacct: Show all detail stats in one file Message-ID: <20160517083924.GA10776@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Zhao Lei wrote: > 1: Rewrite subject and changelog to fix typos and > make it more accurate. So this is really annoying. In the previous review I suggested this: " - please fix the title of the patch: have a look at 'git log kernel/sched/cpuacct.c' how recent titles to that code look like. " If you do what I suggested, you see this title: sched/cpuacct: Check for NULL when using task_pt_regs() Yet you continued to submit using the tag I complained about: cpuacct: Show all detail stats in one file Yes, it's a small detail that I could fix up, but this kind of inability to read very plain suggestions worries me. And yes, if I look further, I see further signs of lack of care: In current code, we can get cpuacct data from severial files, severial? How about at least running a spell checker over the text? ... and I haven't even looked at the code. Thanks, Ingo