From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751895AbcEQMqX (ORCPT ); Tue, 17 May 2016 08:46:23 -0400 Received: from mail.kernel.org ([198.145.29.136]:60388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750995AbcEQMqW (ORCPT ); Tue, 17 May 2016 08:46:22 -0400 Date: Tue, 17 May 2016 09:46:17 -0300 From: Arnaldo Carvalho de Melo To: Adrian Hunter Cc: He Kuang , peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/7 UPDATE2] perf tools: Find vdso with the consider of cross-platform Message-ID: <20160517124617.GD3455@kernel.org> References: <573AC939.8070107@intel.com> <1463475894-163531-1-git-send-email-hekuang@huawei.com> <573AE1A9.1070501@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <573AE1A9.1070501@intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, May 17, 2016 at 12:17:29PM +0300, Adrian Hunter escreveu: > On 17/05/16 12:04, He Kuang wrote: > > There's a problem in machine__findnew_vdso(), vdso buildid generated > > by a 32-bit machine stores it with the name 'vdso', but when > > processing buildid on a 64-bit machine with the same 'perf.data', perf > > will search for vdso named as 'vdso32' and get failed. > > This patch tries to find the exsiting dsos in machine->dsos by thread > > dso_type. 64-bit thread tries to find vdso with name 'vdso', because > > all 64-bit vdso is named as that. 32-bit thread first tries to find > > vdso with name 'vdso32' if this thread was run on 64-bit machine, if > > failed, then it tries 'vdso' which indicates that the thread was run > > on 32-bit machine when recording. > > Signed-off-by: He Kuang > Looks OK. > Acked-by: Adrian Hunter Thanks, applied. - Arnaldo