From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754606AbcEQNpb (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 May 2016 09:45:31 -0400
Received: from mail-pa0-f67.google.com ([209.85.220.67]:34084 "EHLO
	mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751243AbcEQNpa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 May 2016 09:45:30 -0400
Date: Tue, 17 May 2016 23:42:57 +0900
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Calvin Owens <calvinowens@fb.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Howells <dhowells@redhat.com>,
        Pranith Kumar <bobby.prani@gmail.com>,
        David Woodhouse <David.Woodhouse@intel.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Petr Mladek <pmladek@suse.com>, Tejun Heo <tj@kernel.org>,
        Vasily Averin <vvs@virtuozzo.com>, Thierry Reding <treding@nvidia.com>,
        Geliang Tang <geliangtang@163.com>, Ivan Delalande <colona@arista.com>,
        linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [RFC][PATCH] printk: Add option to append kernel version to the
 dict
Message-ID: <20160517144257.GA582@swordfish>
References: <51047c0f6e86abcb9ee13f60653b6946f8fcfc99.1463172791.git.calvinowens@fb.com>
 <20160515063643.GA817@swordfish>
 <20160516220252.GA2281534@devbig337.prn1.facebook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160516220252.GA2281534@devbig337.prn1.facebook.com>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (05/16/16 15:02), Calvin Owens wrote:
[..]
> > > @@ -2305,6 +2317,8 @@ skip:
> > >  						sizeof(ext_text) - ext_len,
> > >  						log_dict(msg), msg->dict_len,
> > >  						log_text(msg), msg->text_len);
> > > +			ext_len += msg_print_ext_uname(ext_text + ext_len,
> > > +						sizeof(ext_text) - ext_len);
> > >  		}
> > 
> > what if there is no place left for init_utsname() after
> > msg_print_ext_header() + msg_print_ext_body()?
> 
> It ends up being truncated, like either of the preceeding calls would.

well, I meant once it's truncated your matching doesn't work anymore.

	-ss