From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbcEQQxN (ORCPT ); Tue, 17 May 2016 12:53:13 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:41978 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800AbcEQQxM (ORCPT ); Tue, 17 May 2016 12:53:12 -0400 Date: Tue, 17 May 2016 10:53:04 -0600 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: andrew.zamansky@nuvoton.com, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v2] tpm: Factor out common startup code Message-ID: <20160517165304.GA19976@obsidianresearch.com> References: <1463423147-9874-1-git-send-email-jgunthorpe@obsidianresearch.com> <20160517041557.GA29299@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160517041557.GA29299@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2016 at 07:15:57AM +0300, Jarkko Sakkinen wrote: > On Mon, May 16, 2016 at 12:25:47PM -0600, Jason Gunthorpe wrote: > > Provide some flags in tpm_class_ops to allow drivers to opt-in to the > > common startup sequence. This is the sequence used by tpm_tis and > > tpm_crb. > > > > All drivers should set this flag. > > The commit message should be a much much more verbose I cannot include > this without a better explanation. Please update this for the next > revision. What more description do you want to see? > > + if (chip->ops->flags & TPM_OPS_PROBE_TPM2) { > > + rc = tpm2_probe(chip); > > + if (rc) > > + return rc; > > + } > > Dead code. Yes, this is used by the follow on driver updates. Andrew is going to be sending a patch that uses it right away. I don't really care if it gets shifted to that patch or not.. Jason