From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752669AbcEQTFi (ORCPT ); Tue, 17 May 2016 15:05:38 -0400 Received: from mail-bl2on0076.outbound.protection.outlook.com ([65.55.169.76]:57515 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752353AbcEQTFf (ORCPT ); Tue, 17 May 2016 15:05:35 -0400 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Tue, 17 May 2016 22:05:26 +0300 From: Yury Norov To: Catalin Marinas CC: , , , , , , , , , , , , Andrew Pinski , , , Andrew Pinski , , , , Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Message-ID: <20160517190526.GA3731@yury-N73SV> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <1459894127-17698-21-git-send-email-ynorov@caviumnetworks.com> <20160514150352.GA30533@yury-N73SV> <20160516170605.GB19290@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160516170605.GB19290@e104818-lin.cambridge.arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [50.233.148.158] X-ClientProxiedBy: CY1PR15CA0010.namprd15.prod.outlook.com (10.163.14.20) To BN4PR07MB2226.namprd07.prod.outlook.com (10.164.63.144) X-MS-Office365-Filtering-Correlation-Id: 75aa8146-008c-467b-7e35-08d37e863796 X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;2:bJaE/Y73j+GnCjNlxZzRETGWRTsWmtp0Irs8QZqE/MwtOZWM70PQB72dGIhmRfzehXPczApfDIqZoqAVhvSj5tC5ImXhWjdJnh8vGqPNjcbMlYAezuA8thLxQGiRu4DfR/n97eoXxzzvAIoJPblq/sBvZ3KEf0ukj1exxl5ar0n8Vez4Oh0BvOjtcT5mGPSg;3:vIQOz/0c7LDkF8xbUKsn5LbXTrZz9cPQJt5dtBYHm9GSutudqiu3UlfaVfj/X6IF1isF3zyovtI/yZFsnF9Sks/TU6R19rSfyLYsa1pWbEKq95+bSBBI45ZakkYtL2hn;25:CDqR+LbITOpwXpfJ7R/s/5BnrSkilHemPdqwgpctfqi0yCZTg9gLtkNDS+NCujTgG3LkZYNHEqXoee255QwSTd07lH/gNv4wfcqXH9W9FdXj4ELY9x/tVI6umYa5oVuwcqmRqaVDSN4ixjhiByp5VSRiWW8LRXjk+Z/rJmwvxvBBN9Hh+tNGjReqo4Eq/czFdZ1XQdsQG/vR0I3u/Un4nAVyRSvAiAk0lbk6Nsk3oh9Hj1aivUNX1GnweLF2AaeJIHxhTvq8c55nsRKQbNUjz/1xt96qT0p+ScIe1tbhHURj7PGHOLle/3bKO6mtEvZQNrjItT+izdWDiqjzR4JkezLmBuZWBE5jUXZdKVfJmYyXK01rwt+Ia79zOy+ApGGNCClwg0x5DAMHyaSDsObo+e3/tvCJ4e5LaAArMSZssGY= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2226; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;20:dYZXMaNv1HAi/cIcHmrAxAUafx8NSzjGpByrwUFB8QQHHPWJNM5xhmYSzN7iGKfdoGrfPWdQQWMXq0FsBmNdw2IC/yi0KSGz6AcPpYg645mT/P1HS0mKCXM5lEM8//Vaj/c0vRy4IeGku6kmUw/sXnY8gA/2lGinKOEVuq6Emqbbdufn8zL3vW7r48nVcbqhZ2JwtppduX4NukByyWRU0Gz8uCx+ypG95cP8acWkzY78x1+e1WVyudtWr/nxR8ibTsdG06cb8Ucy8CH0G+CZZ1nHrCwaRUg44qp42K/19JYyfBachU2oD/WCkBG86GldPCA7mHC01eE//sPWDdASjaLowbXtoCNQAyqIy3TsszVG9bzKpGCdVws8E7EVAGgnHbzZCXtFSZYIjhTdnmGU1yhNXdtEgGjIxUnuiTxXhqEkcvp3s6P5eChVC+Wt/HKBdZ1v2MJXJfHQpzcssKZLAfgyF9QP6ayHQs/Knucj7sIqxfoRoA0BUWkd0kSks3aPVsAjn/vCvyUiJwe0pzqJIsyZTgVFKW21U+UP3LV3re+zSQagTyxDHn/HoReGrdr505tc2Qj/bXxhhrVT15jrx0ln5lJmc9fhtDol9LsPlHs= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:BN4PR07MB2226;BCL:0;PCL:0;RULEID:;SRVR:BN4PR07MB2226; X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;4:FjuYPCj5EdE+3Om4xElmiLSX+xl95I/gfw3EKyXEYMXH3XSDQYNOrBj4sDEYb9KleK9LzpQDpjBXncd0RGapETFlPyylUs/mriaNNROmGpyTk0mj84NdqealL3MNybprbN9hdB+XDUUcSfNJdnh33iqrHukO0FoVHKFonitnZNYF3GwRBNSWJ9DIiUMQ10lKBr6pJA561NYLfuvu0rh/ALE5ERNkYx+KLRuXnVBBAjzr1MtU1w3wj4ldFpQA1wzO/CDgbga3ovN/uPHKPR0i6MFxIdwiUxRQMNAJctq5dOPqa1Q4oh4yHW/8MqaiV2WPHOOaXyRAbIi5lz7lsfa2KjhYJm4R6NKrJSN7zTciM8GqMdZtSCmn68mUIJXCZ4Et X-Forefront-PRVS: 0945B0CC72 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6069001)(6009001)(24454002)(77096005)(42186005)(2950100001)(50466002)(2906002)(76506005)(46406003)(4326007)(81166006)(47776003)(23726003)(5008740100001)(4001350100001)(189998001)(1076002)(3846002)(586003)(110136002)(6116002)(33716001)(5004730100002)(76176999)(50986999)(93886004)(9686002)(83506001)(54356999)(66066001)(92566002)(33656002)(8676002)(97756001)(21314002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR07MB2226;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN4PR07MB2226;23:D29YmJZBvpEL4HbV0e5Q2eax7Ghya4syhhjv3thGj?= =?us-ascii?Q?cOM2lg32tf2vs4ljReVjL3NmZ4FFPTaRr1GONOpdWiG6lqyjofK1TKAH3AHA?= =?us-ascii?Q?ZZZx95NBXMZvEsLplxueUdggcJYCgR3gGkFSLwwi68HO9rL3+0rfRjhxdG5u?= =?us-ascii?Q?3pgYHKuyyRXLC1FMTsC61iDQam//6jFo7LGhCHsfdzDmSMCob/NMPSS993on?= =?us-ascii?Q?dgj53cN0AAUiMVdCmtulOcKyTIvs/1I175GJ2047P7xZgvMbS8Gko9tZjmOz?= =?us-ascii?Q?096xYMNq6yrdCeb1orIwt2uElYiAuJXo1STphzD5jAl4kHpPrnzqvbHJPVht?= =?us-ascii?Q?W25hRpNW6bgTz+68+wrZ/h/oyuQUozCCG6Vwl0hgz6qapohOJ+j8WtNufC5o?= =?us-ascii?Q?m4bul3YGZrc4JL+jO5YrRuNYI6dWtapGY5o9NfRXiBAYF2lxTxvkYtu8ubL9?= =?us-ascii?Q?NJU+thlewc/Cl+Dt4qc//MyX5yW8zdN4me0UB79zI8WCYod2nu+1GmFWAJ5y?= =?us-ascii?Q?qCZQfQ95IqtCKX8kJmvH7hOfhnz73lqXPql4zoM0iGk5VuEx93V7qnpIDG76?= =?us-ascii?Q?FdomKI3pGsYz/C2avlkt5+ywQNHiAE3Rgu3OXRIlx7z7KNVFgv08XI5GY7dK?= =?us-ascii?Q?nYLPQ2iMLigHvyoAaWjFYfUlZu8PwazvBhvp2iCD08mng+/QgbC8HVABhlu3?= =?us-ascii?Q?AXAw88dj+kU+eUj2N109Pc5drekwlNNJQERAYWRkRLAPFPY+qI3ZHvfH2JMG?= =?us-ascii?Q?m/96zmnfxDBvPoCzSDPcyjBSxWOPn8dhefOQOo1eIt/rYykbfxWC+YJHzwoV?= =?us-ascii?Q?ZfBMckjJsg+buRRe4WrBpzhbDMUgd++AqDjH3Jg0+f8WVcevJKrrABsog7M3?= =?us-ascii?Q?du1B9mJaEpH5Q1cv9RNGLgpP9R+PDn84IDpTNDBt8ptaNzYpK0vh7rC3zOxl?= =?us-ascii?Q?Ug4J5EVvzBxnFbMb2t0+h5I0NKwkLph1dpfGGWqweN3eUwRA8cd8dqJ0vytg?= =?us-ascii?Q?1I=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR07MB2226;5:altNvpgN0pGl8VZEDTUGJ7T8D4bArMAuhwWVhnYjmZMi6VpKldd59vK666ViM0tNsuW81VR6WosoYjtwVY9HxCLS1/0eU6SySSfVd7OvRhL2iNp2EqGvqMRLuRGtnRxCXOH8UmzT24Kp9Eu79ZWwyA==;24:syJgtq3QlCgDzNPhL5fx4Xhk3ri69GCAAI2QX6IYpkr3pRyKKvK+VijhpyWnimBIIJNGTiQUVpEJidY8wAlWrtgy6SGjD3uT78piM1BzlXw=;7:U6h6RS7VWDzYlf+cVXcnyde30zqvGwYDtp66qXkiS8GerfZual2YWONHQk111JrOwVyu6js9LpoHQWpJKBV1q9zbL/gyY8Imn1GJIpFrhpqmYLwTpidoEl+cq0052vSdfgc8s9i469h0LEGIoSfZrqlvL1FQU0u0WIF4te7tYzrkRW5SMu3OiA6BKkfcjpnK SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2016 19:05:31.0667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2226 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2016 at 06:06:05PM +0100, Catalin Marinas wrote: > On Sat, May 14, 2016 at 06:03:52PM +0300, Yury Norov wrote: > > +SYSCALL_DEFINE6(mmap2, unsigned long, addr, unsigned long, len, > > + unsigned long, prot, unsigned long, flags, unsigned long, fd, > > + unsigned long, pgoff) > > To avoid the types confusion we could add __SC_WRAP to mmap2 in unistd.h > and use COMPAT_SYSCALL_DEFINE6 here (together with compat_ptr_t etc.). > > > +{ > > + if (pgoff & (~PAGE_MASK >> 12)) > > + return -EINVAL; > > + > > + return sys_mmap_pgoff((compat_uptr_t) addr, (compat_size_t) len, > > + (int) prot, (int) flags, (int) fd, > > + pgoff >> (PAGE_SHIFT-12)); > > Then we wouldn't need the explicit casting here. See below > > > +} > > + > > +COMPAT_SYSCALL_DEFINE4(pread64, unsigned int, fd, compat_uptr_t __user *, ubuf, > > + compat_size_t, count, off_t, offset) > > +{ > > + return sys_pread64(fd, (char *) ubuf, count, offset); > > +} > > + > > +COMPAT_SYSCALL_DEFINE4(pwrite64, unsigned int, fd, compat_uptr_t __user *, ubuf, > > + compat_size_t, count, off_t, offset) > > +{ > > + return sys_pwrite64(fd, (char *) ubuf, count, offset); > > Nitpick: no space between cast type and variable name: (char *)ubuf, ... I think it's really a matter of taste. I prefer to have a space, and there's no solid rule in coding style. And there are 13032 insertions of my version vs 35030 of yours: ~/work/linux$ git grep ' \*)[a-zA-Z]'|wc -l 35030 ~/work/linux$ git grep ' \*) [a-zA-Z]'|wc -l 13032 Of course, I will change it if you insist. > We can also make these functions static as they are not used outside > this file. If it's OK, we can use just compat_sys_xxx() instead of COMPAT_SYSCALL_DEFINEx(xxx), and for mmap2 we'll not need to change _SYSCALL to _SC_WRAP in unistd.h that way. > > -- > Catalin