From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751549AbcEQUb6 (ORCPT ); Tue, 17 May 2016 16:31:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:36446 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbcEQUb4 (ORCPT ); Tue, 17 May 2016 16:31:56 -0400 Date: Tue, 17 May 2016 13:31:54 -0700 From: Greg Kroah-Hartman To: "Jon Medhurst (Tixy)" Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Kees Cook , Catalin Marinas , Guenter Roeck , Arun Chandran Subject: Re: [PATCH 3.14 17/17] arm64: Make arch_randomize_brk avoid stack area Message-ID: <20160517203154.GA15566@kroah.com> References: <20160517011346.950684325@linuxfoundation.org> <20160517011347.610010090@linuxfoundation.org> <1463478563.2555.27.camel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463478563.2555.27.camel@linaro.org> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 17, 2016 at 10:49:23AM +0100, Jon Medhurst (Tixy) wrote: > On Mon, 2016-05-16 at 18:14 -0700, Greg Kroah-Hartman wrote: > > 3.14-stable review patch. If anyone has any objections, please let me know. > > As reported by Guenter Roeck, this patch doesn't compile on 3.14 because > it deleted randomize_base which is still used by the macro > ELF_ET_DYN_BASE. That use was removed in 3.18 by commit 92980405f353 > ("arm64: ASLR: Don't randomise text when randomise_va_space == 0") > > Looking at that commit it seems to be what caused the bug $subject patch > fixes because it stopped the arm64 implementation putting loaded > binaries 2/3rds the way up a task's address range. > > So it seems to me, either $subject patch should only be applied to > Linux versions 3.18 through 4.0 inclusive; or the fix in commit > 92980405f353 also needs backporting to stable kernels before 3.18. (Or > some more other solution.) Thanks, I'll just drop this from 3.14-stable, as it doesn't seem to make much sense for it to be backported there. greg k-h