From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751758AbcERGhc (ORCPT ); Wed, 18 May 2016 02:37:32 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:52403 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbcERGhb (ORCPT ); Wed, 18 May 2016 02:37:31 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: ego@linux.vnet.ibm.com X-IBM-RcptTo: mpe@ellerman.id.au;linuxppc-dev@lists.ozlabs.org;mikey@neuling.org;paulus@ozlabs.org;linux-kernel@vger.kernel.org Date: Wed, 18 May 2016 12:07:09 +0530 From: Gautham R Shenoy To: "Shreyas B. Prabhu" Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, paulus@ozlabs.org, linux-kernel@vger.kernel.org, mikey@neuling.org Subject: Re: [PATCH v2 4/9] powerpc/powernv: Make power7_powersave_common more generic Message-ID: <20160518063708.GD3939@in.ibm.com> Reply-To: ego@linux.vnet.ibm.com References: <1462263878-25237-1-git-send-email-shreyas@linux.vnet.ibm.com> <1462263878-25237-5-git-send-email-shreyas@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462263878-25237-5-git-send-email-shreyas@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16051806-8236-0000-0000-000031492F33 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shreyas, On Tue, May 03, 2016 at 01:54:33PM +0530, Shreyas B. Prabhu wrote: > power7_powersave_common does common steps needed before entering idle > state and eventually changes MSR to MSR_IDLE and does rfid to > power7_enter_nap_mode. > > Make it more generic by passing the rfid address as a function parameter. > Also make function name more generic. [..snip..] > > _GLOBAL(power7_winkle) > - li r3,3 > + li r3,PNV_THREAD_WINKLE This particular change above can go as an independent patch. > > _GLOBAL(power7_wakeup_tb_loss) > diff --git a/arch/powerpc/kernel/idle_power_common.S b/arch/powerpc/kernel/idle_power_common.S > index 05954ae..ff7a541 100644 > --- a/arch/powerpc/kernel/idle_power_common.S > +++ b/arch/powerpc/kernel/idle_power_common.S > @@ -21,8 +21,10 @@ > * To check IRQ_HAPPENED in r4 > * 0 - don't check > * 1 - check > + * > + * Address to 'rfid' to in r5 > */ > -_GLOBAL(power7_powersave_common) > +_GLOBAL(power_powersave_common) > /* Use r3 to pass state nap/sleep/winkle */ > /* NAP is a state loss, we create a regs frame on the > * stack, fill it up with the state we care about and > @@ -79,13 +81,12 @@ _GLOBAL(power7_powersave_common) > * because as soon as we do that, another thread can switch > * the MMU context to the guest. > */ > - LOAD_REG_IMMEDIATE(r5, MSR_IDLE) > + LOAD_REG_IMMEDIATE(r7, MSR_IDLE) > li r6, MSR_RI > andc r6, r9, r6 > - LOAD_REG_ADDR(r7, power7_enter_nap_mode) > mtmsrd r6, 1 /* clear RI before setting SRR0/1 */ > - mtspr SPRN_SRR0, r7 > - mtspr SPRN_SRR1, r5 > + mtspr SPRN_SRR0, r5 > + mtspr SPRN_SRR1, r7 > rfid > /* No return */ Any particular reason why you swapped the roles of r5 and r7 ? -- Thanks and Regards gautham.