From: Steven Rostedt <rostedt@goodmis.org>
To: Jason Wang <jasowang@redhat.com>
Cc: Jesper Dangaard Brouer <brouer@redhat.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
davem@davemloft.net, mst@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH net-next] tuntap: introduce tx skb ring
Date: Wed, 18 May 2016 07:52:06 -0400 [thread overview]
Message-ID: <20160518075206.0ca4c500@grimm.local.home> (raw)
In-Reply-To: <573C42B4.6040708@redhat.com>
On Wed, 18 May 2016 18:23:48 +0800
Jason Wang <jasowang@redhat.com> wrote:
>
> >
> >
> > Maybe Steven Rostedt have an even better ring queue implementation
> > already avail in the kernel?
> >
>
> You mean ring buffer in tracing? Not sure, but it looks rather complex
> at first glance.
Yes it is, and I'm not sure it would be appropriate here or not. The
tracing ring buffer is highly tuned to be lockless and per cpu
(allocates a buffer per cpu), it also does not need to disable
interrupts and can be used in NMI context.
The complexity comes from being able to locklessly swap out pages from
the ring buffer to send across the network or to disk while a record is
happening.
Perf has a simpler ring buffer made for mmapping, but it's still rather
coupled with the perf core. It would be nice to make that ring buffer a
bit more generic and not so tied to perf itself.
-- Steve
next prev parent reply other threads:[~2016-05-18 11:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 1:17 [PATCH net-next] tuntap: introduce tx skb ring Jason Wang
2016-05-16 3:56 ` Eric Dumazet
2016-05-16 7:51 ` Jason Wang
2016-05-18 8:13 ` Jesper Dangaard Brouer
2016-05-18 8:23 ` Michael S. Tsirkin
2016-05-18 10:23 ` Jason Wang
2016-05-18 11:52 ` Steven Rostedt [this message]
2016-05-18 16:26 ` Michael S. Tsirkin
2016-05-18 16:41 ` Eric Dumazet
2016-05-18 16:46 ` Michael S. Tsirkin
2016-05-19 11:59 ` Jesper Dangaard Brouer
2016-05-16 4:23 ` Michael S. Tsirkin
2016-05-16 7:52 ` Jason Wang
2016-05-16 8:08 ` Michael S. Tsirkin
2016-05-17 1:38 ` Jason Wang
2016-05-18 8:16 ` Jesper Dangaard Brouer
2016-05-18 8:21 ` Michael S. Tsirkin
2016-05-18 9:21 ` Jesper Dangaard Brouer
2016-05-18 9:55 ` Michael S. Tsirkin
2016-05-18 10:42 ` Jason Wang
2016-05-18 10:58 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518075206.0ca4c500@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox