public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Alexander Stein <alexander.stein@systec-electronic.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	john@phrozen.org
Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver
Date: Wed, 18 May 2016 19:01:09 +0200	[thread overview]
Message-ID: <20160518170109.GE25448@lunn.ch> (raw)
In-Reply-To: <573C9738.4040402@gmail.com>

> For LEDs, we had a patch series floating around adding LED triggers [1],
> and it seems to me like the LEDs class subsystem would be a good fit for
> controlling PHY LEDs, possibly with the help of PHYLIB when it comes to
> doing the low-level work of registering LEDs and their names with the
> LEDS subsystem.
> 
> [1]: http://lists.openwall.net/netdev/2016/03/23/61

That patch fizzled out. I got the feeling it was pushing the
capabilities of the coder. I do however think it is a reasonable path
to follow for PHY LEDs.

I took a quick look at the datasheet and the controlling of the LEDs
is very flexible. It should not be a problem to expose some of that
functionality via LED triggers.

      Andrew

  reply	other threads:[~2016-05-18 17:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 16:03 [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein
2016-05-18 16:24 ` Florian Fainelli
2016-05-18 17:01   ` Andrew Lunn [this message]
2016-05-19  7:05     ` Alexander Stein
2016-05-19 12:15       ` Andrew Lunn
2016-05-19  4:50   ` John Crispin
2016-05-19  6:57     ` Alexander Stein
2016-05-19  7:03       ` John Crispin
2016-05-19  7:28         ` Alexander Stein
2016-05-19 10:03         ` Mathias Kresin
2016-05-19 10:21           ` Alexander Stein
2016-05-23  9:12             ` Mehrtens, Hauke
2016-05-23  9:49               ` Alexander Stein
2016-05-23 10:07                 ` Mathias Kresin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160518170109.GE25448@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=alexander.stein@systec-electronic.com \
    --cc=f.fainelli@gmail.com \
    --cc=john@phrozen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox