From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932632AbcERRBO (ORCPT ); Wed, 18 May 2016 13:01:14 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:41326 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753065AbcERRBM (ORCPT ); Wed, 18 May 2016 13:01:12 -0400 Date: Wed, 18 May 2016 19:01:09 +0200 From: Andrew Lunn To: Florian Fainelli Cc: Alexander Stein , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, john@phrozen.org Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Message-ID: <20160518170109.GE25448@lunn.ch> References: <1463587403-26809-1-git-send-email-alexander.stein@systec-electronic.com> <573C9738.4040402@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <573C9738.4040402@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > For LEDs, we had a patch series floating around adding LED triggers [1], > and it seems to me like the LEDs class subsystem would be a good fit for > controlling PHY LEDs, possibly with the help of PHYLIB when it comes to > doing the low-level work of registering LEDs and their names with the > LEDS subsystem. > > [1]: http://lists.openwall.net/netdev/2016/03/23/61 That patch fizzled out. I got the feeling it was pushing the capabilities of the coder. I do however think it is a reasonable path to follow for PHY LEDs. I took a quick look at the datasheet and the controlling of the LEDs is very flexible. It should not be a problem to expose some of that functionality via LED triggers. Andrew