From: Greg KH <gregkh@linuxfoundation.org>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: David Kershner <david.kershner@unisys.com>,
corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, erik.arfvidson@unisys.com,
timothy.sell@unisys.com, hofrat@osadl.org, dzickus@redhat.com,
alexander.curtin@unisys.com, janani.rvchndrn@gmail.com,
sudipm.mukherjee@gmail.com, prarit@redhat.com,
david.binder@unisys.com, nhorman@redhat.com,
dan.j.williams@intel.com, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
driverdev-devel@linuxdriverproject.org,
sparmaintainer@unisys.com
Subject: Re: [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86
Date: Wed, 18 May 2016 10:26:37 -0700 [thread overview]
Message-ID: <20160518172637.GB6879@kroah.com> (raw)
In-Reply-To: <wrfj8tz7z72p.fsf@redhat.com>
On Wed, May 18, 2016 at 12:03:58PM -0400, Jes Sorensen wrote:
> Greg KH <gregkh@linuxfoundation.org> writes:
> > On Tue, May 17, 2016 at 07:49:53PM -0400, Jes Sorensen wrote:
> >> > Ok, but still no need to put it under arch/ anything, it should go in
> >> > drivers/ like all other drivers and busses are, no matter what the arch
> >> > it happens to run on is.
> >>
> >> I don't think thats obvious. arch/x86/kvm is an example of this, Sparc
> >> and PPC also have their stuff under arch/.
> >
> > For some things, yes, but let's not make the same mistakes as others :)
> >
> > Look at drivers/hv/ for an example of a very x86-only bus and driver
> > subsystem living in drivers/ Please don't burry driver stuff in arch/
> > the ARM developers are trying to fix their mistakes of the past and move
> > all of their cruft out of arch/ for that reason.
>
> Works for me.
>
> So should they put it in drivers/visorbus or drivers/bus/visorbus?
drivers/visorbus please. drivers/bus/ is an "odd" thing :(
> What about drivers/virt? Would you suggest hv and xen gets moved in
> there?
Ah, yeah, that would be great, never noticed it before, despite being
there since 2011...
thanks,
greg k-h
prev parent reply other threads:[~2016-05-18 17:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 7:27 [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices to arch/x86 David Kershner
2016-05-17 7:27 ` [PATCH 1/5] staging: unisys: Move vbushelper.h to visorbus directory David Kershner
2016-05-17 7:27 ` [PATCH 2/5] include: linux: visorbus: Add visorbus to include/linux directory David Kershner
2016-05-17 7:27 ` [PATCH 3/5] Documentation: Move visorbus documentation from staging to Documentation/ David Kershner
2016-05-17 13:50 ` Greg KH
2016-05-17 7:28 ` [PATCH 4/5] staging: unisys: visorbus: Have visorbus use include/linux/visorbus David Kershner
2016-05-17 13:52 ` Greg KH
2016-05-17 7:28 ` [PATCH 5/5] arch: x86: add visorbus directory to arch/x86 David Kershner
2016-05-17 13:51 ` [PATCH 0/5] add bus driver for Unisys s-Par paravirtualized devices " Greg KH
2016-05-17 14:01 ` Jes Sorensen
2016-05-17 14:27 ` Greg KH
2016-05-17 23:49 ` Jes Sorensen
2016-05-18 0:03 ` Greg KH
2016-05-18 16:03 ` Jes Sorensen
2016-05-18 17:26 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518172637.GB6879@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Jes.Sorensen@redhat.com \
--cc=alexander.curtin@unisys.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=david.binder@unisys.com \
--cc=david.kershner@unisys.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=dzickus@redhat.com \
--cc=erik.arfvidson@unisys.com \
--cc=hofrat@osadl.org \
--cc=hpa@zytor.com \
--cc=janani.rvchndrn@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@redhat.com \
--cc=prarit@redhat.com \
--cc=sparmaintainer@unisys.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=tglx@linutronix.de \
--cc=timothy.sell@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox