From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754730AbcESNUR (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 May 2016 09:20:17 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:46811 "EHLO
	bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754356AbcESNUQ convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 May 2016 09:20:16 -0400
Date: Thu, 19 May 2016 10:20:07 -0300
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
To: Christian =?iso-8859-1?Q?K=F6nig?= <christian.koenig@amd.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
        Gustavo Padovan <gustavo@padovan.org>, dri-devel@lists.freedesktop.org,
        marcheu@google.com, Daniel Stone <daniels@collabora.com>,
        seanpaul@google.com, Daniel Vetter <daniel.vetter@ffwll.ch>,
        linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com,
        Alex Deucher <alexander.deucher@amd.com>,
        John Harrison <John.C.Harrison@Intel.com>, m.chehab@samsung.com
Subject: Re: [PATCH 1/2] dma-buf/fence: add fence_collection fences
Message-ID: <20160519132007.GA15155@joana>
References: <1463605193-18040-1-git-send-email-gustavo@padovan.org>
 <20160518225710.GA32627@nuc-i3427.alporthouse.com>
 <573D6F67.7070109@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8BIT
In-Reply-To: <573D6F67.7070109@amd.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Christian,

2016-05-19 Christian König <christian.koenig@amd.com>:

> Am 19.05.2016 um 00:57 schrieb Chris Wilson:
> > On Wed, May 18, 2016 at 05:59:52PM -0300, Gustavo Padovan wrote:
> > > +static void collection_check_cb_func(struct fence *fence, struct fence_cb *cb)
> > > +{
> > > +	struct fence_collection_cb *f_cb;
> > > +	struct fence_collection *collection;
> > > +
> > > +	f_cb = container_of(cb, struct fence_collection_cb, cb);
> > > +	collection = f_cb->collection;
> > > +
> > > +	if (atomic_dec_and_test(&collection->num_pending_fences))
> > > +		fence_signal(&collection->base);
> > > +}
> > > +
> > > +static bool fence_collection_enable_signaling(struct fence *fence)
> > > +{
> > > +	struct fence_collection *collection = to_fence_collection(fence);
> > > +	int i;
> > > +
> > > +	for (i = 0 ; i < collection->num_fences ; i++) {
> > > +		if (fence_add_callback(collection->fences[i].fence,
> > > +				       &collection->fences[i].cb,
> > > +				       collection_check_cb_func)) {
> > > +			atomic_dec(&collection->num_pending_fences);
> > > +		}
> > > +	}
> > We don't always have a convenient means to preallocate an array of
> > fences to use. Keeping a list of fences in addition to the array would
> > be easier to user in many circumstances.
> 
> I agree that there is use for such an implementation as well, but as
> mentioned in the last review cycle we intentionally chose an array instead
> of a more complex implementation here.
> 
> This way the array can be passed to function like fence_wait_any_timeout()
> as well.
> 
> I also suggested to rename it to fence_array to make that difference clear
> and allow for another implementation to live side by side with this.
> 
> My crux at the moment is that I need both for the amdgpu driver, an array
> based implementation and a collection like one.
> 
> Gustavo would you mind if I take your patches and work a bit on this?

Please go ahead with this and let me know if you need anything from me.

	Gustavo