From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932814AbcESTOJ (ORCPT ); Thu, 19 May 2016 15:14:09 -0400 Received: from mail-yw0-f174.google.com ([209.85.161.174]:35814 "EHLO mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbcESTOI (ORCPT ); Thu, 19 May 2016 15:14:08 -0400 Date: Thu, 19 May 2016 15:14:00 -0400 From: William Breathitt Gray To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, "James E.J. Bottomley" , "Martin K. Petersen" , Stephen Rothwell , linux-next@vger.kernel.org, linux-scsi Subject: Re: [PATCH] scsi: ultrastor.c depends on ISA_DMA_API Message-ID: <20160519191400.GA16573@sophia> References: <20160519164501.4cc8bc4f@canb.auug.org.au> <573DFE8B.2070808@infradead.org> <20160519185335.GA18253@sophia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160519185335.GA18253@sophia> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2016 at 02:53:35PM -0400, William Breathitt Gray wrote: >Although request_dma and free_dma are conditionally dependent on >CONFIG_ISA_DMA_API inside the arch/x86/include/asm/dma.h file, they are >defined inside the kernel/dma.c file which depends on >CONFIG_GENERIC_ISA_DMA in order to build on X86. Therefore, >GENERIC_ISA_DMA should be in the depends line for SCSI_ULTRASTOR instead >of ISA_DMA_API. > >William Breathitt Gray My apologies, I was too quick to send and didn't realize CONFIG_GENERIC_ISA_DMA is "def_bool y" in X86. In that case, ISA_DMA_API should suffice; thus the line becomes: depends X86 && SCSI && ISA_DMA_API William Breathitt Gray