From: Borislav Petkov <bp@alien8.de>
To: nick <xerofoify@gmail.com>
Cc: dougthompson@xmission.com, mchehab@osg.samsung.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH] edac:Fix kernel panic regression in edac_mc_reset_delay_period
Date: Fri, 20 May 2016 00:27:11 +0200 [thread overview]
Message-ID: <20160519222711.GF552@pd.tnic> (raw)
In-Reply-To: <573E39DD.7080603@gmail.com>
On Thu, May 19, 2016 at 06:10:37PM -0400, nick wrote:
> Here is the issue though it does not happen on v4.4 but on newer
> kernels. I bisected it and it does work if the commit I stated is
> reverted, and working at that commit the only line changed in any
> function is in my patch. Here we can add a check like your asking:
This is not what I hinted at. I hinted at checking ->op_state in
edac_mc_reset_delay_period() before doing edac_mod_work().
Here's another hint: ->op_state gets set to OP_RUNNING_POLL only when
->edac_check is not NULL.
Better?
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
prev parent reply other threads:[~2016-05-19 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1463687097-11306-1-git-send-email-xerofoify@gmail.com>
2016-05-19 21:44 ` [PATCH] edac:Fix kernel panic regression in edac_mc_reset_delay_period Borislav Petkov
[not found] ` <573E39DD.7080603@gmail.com>
2016-05-19 22:27 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160519222711.GF552@pd.tnic \
--to=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=rostedt@goodmis.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox