From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755195AbcESW13 (ORCPT ); Thu, 19 May 2016 18:27:29 -0400 Received: from mail.skyhub.de ([78.46.96.112]:56894 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751646AbcESW11 (ORCPT ); Thu, 19 May 2016 18:27:27 -0400 Date: Fri, 20 May 2016 00:27:11 +0200 From: Borislav Petkov To: nick Cc: dougthompson@xmission.com, mchehab@osg.samsung.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Steven Rostedt Subject: Re: [PATCH] edac:Fix kernel panic regression in edac_mc_reset_delay_period Message-ID: <20160519222711.GF552@pd.tnic> References: <1463687097-11306-1-git-send-email-xerofoify@gmail.com> <20160519214455.GE552@pd.tnic> <573E39DD.7080603@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <573E39DD.7080603@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2016 at 06:10:37PM -0400, nick wrote: > Here is the issue though it does not happen on v4.4 but on newer > kernels. I bisected it and it does work if the commit I stated is > reverted, and working at that commit the only line changed in any > function is in my patch. Here we can add a check like your asking: This is not what I hinted at. I hinted at checking ->op_state in edac_mc_reset_delay_period() before doing edac_mod_work(). Here's another hint: ->op_state gets set to OP_RUNNING_POLL only when ->edac_check is not NULL. Better? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.