From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755400AbcETAFp (ORCPT ); Thu, 19 May 2016 20:05:45 -0400 Received: from one.firstfloor.org ([193.170.194.197]:44163 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753929AbcETAFo (ORCPT ); Thu, 19 May 2016 20:05:44 -0400 Date: Thu, 19 May 2016 17:05:40 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, peterz@infradead.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 10/10] perf, tools, stat: Add extra output of counter values with -vv Message-ID: <20160520000539.GP13997@two.firstfloor.org> References: <1462489447-31832-1-git-send-email-andi@firstfloor.org> <1462489447-31832-11-git-send-email-andi@firstfloor.org> <20160512080343.GB14734@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160512080343.GB14734@krava> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > hi, > we already have similar output for aggregated counters, > could you please consider something like below to clearly > separate them? I think Arnaldo has already merged the patch, so he should merge the fix too. The fix is fine for me. -Andi > > [root@ibm-x3650m4-01 perf]# ./perf stat -e cycles -I 1000 -vv -a -C 0,1 > ... > cycles: CPU 0: 1298783264 1000126956 1000126956 > cycles: CPU 1: 1298791660 1000134589 1000134589 > cycles: AGGR: 2597574924 2000261545 2000261545 > ... > > thanks, > jirka > > > --- > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 7c5c50b61b28..bd0d67ebb757 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -316,7 +316,7 @@ static int read_counter(struct perf_evsel *counter) > > if (verbose > 1) { > fprintf(stat_config.output, > - "%s: %d: %" PRIu64 " %" PRIu64 " %" PRIu64 "\n", > + "%s: CPU %d: %" PRIu64 " %" PRIu64 " %" PRIu64 "\n", > perf_evsel__name(counter), > cpu, > count->val, count->ena, count->run); > diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c > index c1ba255f2abe..5ddeea1399ee 100644 > --- a/tools/perf/util/stat.c > +++ b/tools/perf/util/stat.c > @@ -345,7 +345,7 @@ int perf_stat_process_counter(struct perf_stat_config *config, > update_stats(&ps->res_stats[i], count[i]); > > if (verbose) { > - fprintf(config->output, "%s: %" PRIu64 " %" PRIu64 " %" PRIu64 "\n", > + fprintf(config->output, "%s: AGGR: %" PRIu64 " %" PRIu64 " %" PRIu64 "\n", > perf_evsel__name(counter), count[0], count[1], count[2]); > } > > -- ak@linux.intel.com -- Speaking for myself only.