From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754817AbcETEI7 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 20 May 2016 00:08:59 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:34732 "EHLO
	mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753340AbcETEI6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 May 2016 00:08:58 -0400
Date: Fri, 20 May 2016 13:08:36 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dan Streetman <ddstreet@ieee.org>
Cc: Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
        Ganesh Mahendran <opensource.ganesh@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Seth Jennings <sjenning@redhat.com>, Yu Zhao <yuzhao@google.com>,
        Linux-MM <linux-mm@kvack.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Dan Streetman <dan.streetman@canonical.com>
Subject: Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info
Message-ID: <20160520040836.GA573@swordfish>
References: <CADAEsF-kaCQnNN_9gySw3J0UT4mGh8KFp75tGSJtaDAuN1T10A@mail.gmail.com>
 <1463671123-5479-1-git-send-email-ddstreet@ieee.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463671123-5479-1-git-send-email-ddstreet@ieee.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (05/19/16 11:18), Dan Streetman wrote:
[..]
>  	zs_stat_root = debugfs_create_dir("zsmalloc", NULL);
>  	if (!zs_stat_root)
> -		return -ENOMEM;
> -
> -	return 0;
> +		pr_warn("debugfs 'zsmalloc' stat dir creation failed\n");
>  }
>  
>  static void __exit zs_stat_exit(void)
> @@ -573,17 +575,19 @@ static const struct file_operations zs_stat_size_ops = {
>  	.release        = single_release,
>  };
>  
> -static int zs_pool_stat_create(struct zs_pool *pool, const char *name)
> +static void zs_pool_stat_create(struct zs_pool *pool, const char *name)
>  {
>  	struct dentry *entry;
>  
> -	if (!zs_stat_root)
> -		return -ENODEV;
> +	if (!zs_stat_root) {
> +		pr_warn("no root stat dir, not creating <%s> stat dir\n", name);
> +		return;
> +	}

just a small nit, there are basically two warn messages now for
`!zs_stat_root':

	debugfs 'zsmalloc' stat dir creation failed
	no root stat dir, not creating <%s> stat dir

may be we need only one of them; but no strong opinions.

	-ss