From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933270AbcETInE (ORCPT ); Fri, 20 May 2016 04:43:04 -0400 Received: from mail.skyhub.de ([78.46.96.112]:51545 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932540AbcETInB (ORCPT ); Fri, 20 May 2016 04:43:01 -0400 Date: Fri, 20 May 2016 10:42:44 +0200 From: Borislav Petkov To: Nicholas Krause Cc: dougthompson@xmission.com, mchehab@osg.samsung.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] edac:Fix kernel panic regression in edac_mc_reset_delay_period due to missing mode operation check Message-ID: <20160520084244.GA501@pd.tnic> References: <1463697958-13406-1-git-send-email-xerofoify@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1463697958-13406-1-git-send-email-xerofoify@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 19, 2016 at 06:45:58PM -0400, Nicholas Krause wrote: > This fixes a kernel panic regression in the function, > edac_mc_reset_delay_period as show by this kernel panic > trace: ... > drivers/edac/edac_mc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c > index 6aa256b0..c3ee3ad 100644 > --- a/drivers/edac/edac_mc.c > +++ b/drivers/edac/edac_mc.c > @@ -565,7 +565,8 @@ void edac_mc_reset_delay_period(unsigned long value) > list_for_each(item, &mc_devices) { > mci = list_entry(item, struct mem_ctl_info, link); > > - edac_mod_work(&mci->work, value); > + if (mci->op_state == OP_RUNNING_POLL) > + edac_mod_work(&mci->work, value); > } > mutex_unlock(&mem_ctls_mutex); > } > -- Looks good to me. I'll apply it after the merge window is over. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.