From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933358AbcETJK5 (ORCPT ); Fri, 20 May 2016 05:10:57 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33347 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932150AbcETJKy (ORCPT ); Fri, 20 May 2016 05:10:54 -0400 Date: Fri, 20 May 2016 11:10:50 +0200 From: Carlo Caione To: Neil Armstrong Cc: devicetree@vger.kernel.org, xing.xu@amlogic.com, victor.wan@amlogic.com, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, jerry.cao@amlogic.com, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms Message-ID: <20160520091050.GC19888@mephisto> References: <1463732875-23141-1-git-send-email-narmstrong@baylibre.com> <1463732875-23141-4-git-send-email-narmstrong@baylibre.com> <20160520084748.GC16732@mephisto> <573ED06F.9070909@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <573ED06F.9070909@baylibre.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/16 10:53, Neil Armstrong wrote: > On 05/20/2016 10:47 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> Update DTSI file to add the reset controller node. > >> > >> Signed-off-by: Neil Armstrong > >> --- > >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > >> index 832815d..2463e04 100644 > >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > >> @@ -129,6 +129,12 @@ > >> #size-cells = <2>; > >> ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>; > >> > >> + reset: reset-controller@4404 { > >> + compatible = "amlogic,meson-gxbb-reset"; > >> + reg = <0x0 0x04404 0x0 0x20>; > >> + #reset-cells = <1>; > >> + }; > >> + > >> uart_A: serial@84c0 { > >> compatible = "amlogic,meson-uart"; > >> reg = <0x0 0x084c0 0x0 0x14>; > > > > Missing #include ? > > > > Thanks, > > > > Shouldn't we wait until the reset bindings are actually used in the dtsi ? > I'm quite sure kevin will post it with the Ethernet nodes. Why? The header file is related to the reset controller. Better add it now with this patchset. Cheers, -- Carlo Caione