* [PATCH] fs: befs: replace GFP_KERNEL by GFP_NOFS
@ 2016-05-20 11:07 Salah Triki
2016-05-21 0:57 ` Al Viro
0 siblings, 1 reply; 2+ messages in thread
From: Salah Triki @ 2016-05-20 11:07 UTC (permalink / raw)
To: akpm; +Cc: Salah Triki, linux-kernel
Since this is a filesystem driver, using the flag GFP_NOFS is more
appropriate than the flag GFP_KERNEL.
Signed-off-by: Salah Triki <salah.triki@acm.org>
---
fs/befs/linuxvfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
index cc0e082..ef6f6b0 100644
--- a/fs/befs/linuxvfs.c
+++ b/fs/befs/linuxvfs.c
@@ -763,7 +763,7 @@ befs_fill_super(struct super_block *sb, void *data, int silent)
save_mount_options(sb, data);
- sb->s_fs_info = kzalloc(sizeof(*befs_sb), GFP_KERNEL);
+ sb->s_fs_info = kzalloc(sizeof(*befs_sb), GFP_NOFS);
if (sb->s_fs_info == NULL) {
pr_err("(%s): Unable to allocate memory for private "
"portion of superblock. Bailing.\n", sb->s_id);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: befs: replace GFP_KERNEL by GFP_NOFS
2016-05-20 11:07 [PATCH] fs: befs: replace GFP_KERNEL by GFP_NOFS Salah Triki
@ 2016-05-21 0:57 ` Al Viro
0 siblings, 0 replies; 2+ messages in thread
From: Al Viro @ 2016-05-21 0:57 UTC (permalink / raw)
To: Salah Triki; +Cc: akpm, linux-kernel
On Fri, May 20, 2016 at 12:07:08PM +0100, Salah Triki wrote:
> Since this is a filesystem driver, using the flag GFP_NOFS is more
> appropriate than the flag GFP_KERNEL.
What does "more appropriate" mean? Either there is a specific reason, or
it's a cargo-culting, plain and simple. _Why_ does it need GFP_NOFS?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-21 0:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 11:07 [PATCH] fs: befs: replace GFP_KERNEL by GFP_NOFS Salah Triki
2016-05-21 0:57 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox