The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Driver core update for 4.7-rc1
Date: Fri, 20 May 2016 22:39:37 -0700	[thread overview]
Message-ID: <20160521053937.GA31102@kroah.com> (raw)
In-Reply-To: <CA+55aFxk1oVqQRo0mPQejq4myqQ0sHOYr9AgA8+j3RYfFxyESw@mail.gmail.com>

On Fri, May 20, 2016 at 10:20:19PM -0700, Linus Torvalds wrote:
> On Fri, May 20, 2016 at 10:04 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > What warnings?  I haven't seen any reports of warnings, what .config
> > causes them?
> 
> There's tons of them if you just do an allmodconfig build.
> 
> This suddenly enables a lot of random 16-bit ISA driver crap on
> x86-64, and not surprisingly it doesn't build cleanly, nor can most of
> those drivers work.
> 
> I'll just put a smattering of the warnings at the bottom, it scrolls
> off the screen.
> 
> These really are drivers that should not have been enabled. They are
> legacy crap, it's not worth anybodys time to try to "fix" them, they
> just shouldn't be on.
> 
>                  Linus
> 
> ---
> 
> drivers/ide/ht6560b.c: In function ‘ht6560b_init_dev’:
> drivers/ide/ht6560b.c:317:27: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>   ide_set_drivedata(drive, (void *)t);
>                            ^
> drivers/ide/qd65xx.c: In function ‘qd6500_init_dev’:
> drivers/ide/qd65xx.c:295:27: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>   ide_set_drivedata(drive, (void *)QD6500_DEF_DATA);
>                            ^
> drivers/ide/qd65xx.c: In function ‘qd6580_init_dev’:
> drivers/ide/qd65xx.c:311:27: warning: cast to pointer from integer of
> different size [-Wint-to-pointer-cast]
>   ide_set_drivedata(drive, (void *)((drive->dn & 1) ? t2 : t1));
>                            ^
> drivers/net/ethernet/3com/3c515.c: In function ‘corkscrew_start_xmit’:
> drivers/net/ethernet/3com/3c515.c:1066:8: warning: cast from pointer
> to integer of different size [-Wpointer-to-int-cast]
>    outl((int) (skb->data), ioaddr + Wn7_MasterAddr);
>         ^
> drivers/net/ethernet/amd/ni65.c: In function ‘ni65_stop_start’:
> drivers/net/ethernet/amd/ni65.c:756:16: warning: cast from pointer to
> integer of different size [-Wpointer-to-int-cast]
>     buffer[i] = (u32) isa_bus_to_virt(tmdp->u.buffer);
>                 ^
> drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff()
> falls through to next function ds1685_rtc_work_queue()
> drivers/net/wan/sdla.c: In function ‘sdla_transmit’:
> drivers/net/wan/sdla.c:714:13: warning: cast to pointer from integer
> of different size [-Wint-to-pointer-cast]
>       pbuf = (void *)(((int) dev->mem_start) + (addr & SDLA_ADDR_MASK));
>              ^

This is odd, I just tried this, and I don't get any error for
drivers/rtc/rtc-ds1685.c, nor any drivers/rtc/ file.

But I get the warning for drivers/ide/qd65xx.c, so that's not good.

Yeah, just revert it for now, let's not polute the build, sorry about
this.

thanks,

greg k-h

  reply	other threads:[~2016-05-21  5:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-21  3:23 [GIT PULL] Driver core update for 4.7-rc1 Greg KH
2016-05-21  4:51 ` Linus Torvalds
2016-05-21  5:04   ` Greg KH
2016-05-21  5:20     ` Linus Torvalds
2016-05-21  5:39       ` Greg KH [this message]
2016-05-21  6:01         ` Linus Torvalds
2016-05-21 16:20     ` William Breathitt Gray
2016-05-21 16:31       ` Linus Torvalds
2016-05-21 16:59         ` Linus Torvalds
2016-05-21 17:16           ` William Breathitt Gray
2016-05-21 17:23             ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160521053937.GA31102@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vilhelm.gray@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox