From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbcEULRJ (ORCPT ); Sat, 21 May 2016 07:17:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36988 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751086AbcEULRG (ORCPT ); Sat, 21 May 2016 07:17:06 -0400 Date: Sat, 21 May 2016 13:17:03 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 1/2] perf stat: Print topology/time headers with --metric-only Message-ID: <20160521111703.GA5761@krava> References: <1463773815-25984-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1463773815-25984-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sat, 21 May 2016 11:17:06 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 20, 2016 at 12:50:14PM -0700, Andi Kleen wrote: > From: Andi Kleen > > When --metric-only is enabled there were no headers for the topology > in interval mode. Also when headers were printed they were > on a separate line. > > Before: > > $ perf stat --metric-only -A -I 1000 -a > 1.001038376 frontend cycles idle insn per cycle stalled cycles per insn branch-misses of all branches > 1.001038376 CPU0 123.54% 0.23 5.29 7.61% > 1.001038376 CPU1 137.78% 0.24 5.13 10.07% > 1.001038376 CPU2 64.48% 0.22 5.50 6.84% > > After: > > $ perf stat --metric-only -A -I 1000 -a > 1.001111114 CPU0 82.46% 0.32 2.60 7.64% > 1.001111114 CPU1 126.63% 0.02 42.83 0.15% > 1.001111114 CPU2 193.54% 0.32 2.59 6.92% > > v2: Move all headers on a single line changelog is wrong [jolsa@ibm-x3650m4-01 perf]$ sudo ./perf stat --metric-only -A -I 1000 -a # time CPU frontend cycles idle backend cycles idle insn per cycle stalled cycles per insn branch-misses of all branches 1.003232468 CPU0 69.13% 56.43% 0.31 2.20 0.01% 1.003232468 CPU1 69.13% 56.23% 0.31 2.20 0.00% 1.003232468 CPU2 69.11% 56.27% 0.32 2.19 0.00% otherwise Acked-by: Jiri Olsa thanks, jirka