From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools, report: Add srcline_from/to branch sort keys
Date: Sat, 21 May 2016 14:01:51 +0200 [thread overview]
Message-ID: <20160521120151.GA18117@krava> (raw)
In-Reply-To: <1463775308-32748-1-git-send-email-andi@firstfloor.org>
On Fri, May 20, 2016 at 01:15:08PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Add srcline_from and srcline_to branch sort keys that allow
> to show the source lines of a branch. That makes it much easier
> to track down where particular branches happen in the program,
> for example to examine branch mispredictions, or to associate
> it with cycle counts:
>
> % perf record -b -e cycles:p ./tcall
> % perf report --sort srcline_from,srcline_to,mispredict
> ...
> 15.10% tcall.c:18 tcall.c:10 N
> 14.83% tcall.c:11 tcall.c:5 N
> 14.12% tcall.c:7 tcall.c:12 N
> 14.04% tcall.c:12 tcall.c:5 N
> 12.42% tcall.c:17 tcall.c:18 N
> 12.39% tcall.c:7 tcall.c:13 N
> 12.27% tcall.c:13 tcall.c:17 N
> ...
>
> % perf report --sort srcline_from,srcline_to,cycles
> ...
> 17.12% tcall.c:18 tcall.c:11 1
> 17.01% tcall.c:12 tcall.c:6 1
> 16.98% tcall.c:11 tcall.c:6 1
> 15.91% tcall.c:17 tcall.c:18 1
> 6.38% tcall.c:7 tcall.c:17 7
> 4.80% tcall.c:7 tcall.c:12 8
> 4.21% tcall.c:7 tcall.c:17 8
> 2.67% tcall.c:7 tcall.c:12 7
> 2.62% tcall.c:7 tcall.c:12 10
> 2.10% tcall.c:7 tcall.c:17 9
> 1.58% tcall.c:7 tcall.c:12 6
> 1.44% tcall.c:7 tcall.c:12 5
> 1.38% tcall.c:7 tcall.c:12 9
> 1.06% tcall.c:7 tcall.c:17 13
> 1.05% tcall.c:7 tcall.c:12 4
> 1.01% tcall.c:7 tcall.c:17 6
>
> Open issues:
> - Some kernel symbols get misresolved.
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2016-05-21 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 20:15 [PATCH] perf, tools, report: Add srcline_from/to branch sort keys Andi Kleen
2016-05-21 12:01 ` Jiri Olsa [this message]
2016-05-23 14:25 ` Arnaldo Carvalho de Melo
2016-05-24 5:46 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160521120151.GA18117@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox