From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752660AbcEVWZl (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 May 2016 18:25:41 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:44061 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752583AbcEVWZk (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 May 2016 18:25:40 -0400
Date: Sun, 22 May 2016 15:25:38 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tobin C Harding <me@tobin.cc>
Cc: patrik.r.jakobsson@gmail.com, David Airlie <airlied@linux.ie>,
        Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        James Simmons <jsimmons@infradead.org>,
        "John L. Hammond" <john.hammond@intel.com>,
        Dmitry Eremin <dmitry.eremin@intel.com>, Frank Zago <fzago@cray.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Julia Lawall <Julia.Lawall@lip6.fr>, Al Viro <viro@zeniv.linux.org.uk>,
        James Nunez <james.a.nunez@intel.com>,
        Abdul Hussain <habdul@visteon.com>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org,
        devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to
 memdup_user
Message-ID: <20160522222538.GA17573@kroah.com>
References: <1463953771-16942-1-git-send-email-me@tobin.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463953771-16942-1-git-send-email-me@tobin.cc>
User-Agent: Mutt/1.6.1 (2016-04-27)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
> 
> Signed-off-by: Tobin C Harding <me@tobin.cc>

Why did you send this twice?

> ---
>  drivers/gpu/drm/gma500/gma_display.c      |  2 +-
>  drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
>  2 files changed, 8 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index 5bf765d..8a1fb25 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
>  
>  		/* Wait for vblank for the disable to take effect */
>  		gma_wait_for_vblank(dev);
> -
> +l

What?  What does this have to do with lustre?

It's kind of obvious you didn't build this :(

Please be more careful in the future.

greg k-h