From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752796AbcEWDDw (ORCPT <rfc822;w@1wt.eu>);
	Sun, 22 May 2016 23:03:52 -0400
Received: from LGEAMRELO12.lge.com ([156.147.23.52]:44229 "EHLO
	lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752730AbcEWDDv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 22 May 2016 23:03:51 -0400
X-Original-SENDERIP: 156.147.1.125
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 165.244.98.150
X-Original-MAILFROM: minchan@kernel.org
X-Original-SENDERIP: 10.177.223.161
X-Original-MAILFROM: minchan@kernel.org
Date: Mon, 23 May 2016 12:03:58 +0900
From: Minchan Kim <minchan@kernel.org>
To: Dan Streetman <ddstreet@ieee.org>
CC: Nitin Gupta <ngupta@vflare.org>,
        Ganesh Mahendran <opensource.ganesh@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Seth Jennings <sjenning@redhat.com>, Yu Zhao <yuzhao@google.com>,
        Linux-MM <linux-mm@kvack.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Dan Streetman <dan.streetman@canonical.com>
Subject: Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info
Message-ID: <20160523030358.GA6266@bbox>
References: <CADAEsF-kaCQnNN_9gySw3J0UT4mGh8KFp75tGSJtaDAuN1T10A@mail.gmail.com>
 <1463671123-5479-1-git-send-email-ddstreet@ieee.org>
MIME-Version: 1.0
In-Reply-To: <1463671123-5479-1-git-send-email-ddstreet@ieee.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/05/23 12:03:47,
	Serialize by Router on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November
 21, 2013) at 2016/05/23 12:03:47,
	Serialize complete at 2016/05/23 12:03:47
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, May 19, 2016 at 11:18:43AM -0400, Dan Streetman wrote:
> Change the return type of zs_pool_stat_create() to void, and
> remove the logic to abort pool creation if the stat debugfs
> dir/file could not be created.
> 
> The debugfs stat file is for debugging/information only, and doesn't
> affect operation of zsmalloc; there is no reason to abort creating
> the pool if the stat file can't be created.  This was seen with
> zswap, which used the same name for all pool creations, which caused
> zsmalloc to fail to create a second pool for zswap if
> CONFIG_ZSMALLOC_STAT was enabled.
> 
> Signed-off-by: Dan Streetman <ddstreet@ieee.org>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Cc: Dan Streetman <dan.streetman@canonical.com>
> Cc: Minchan Kim <minchan@kernel.org>
Acked-by: Minchan Kim <minchan@kernel.org>

However, Andrew already sent old version to upstream.

Andrew, Could you send revert patch of [1] in linus's tree and send
this instead of it if you have chance?

[1] d34f615720d1 mm/zsmalloc: don't fail if can't create debugfs info

Thanks.