* [PATCH 1/1] drm/mediatek: do not dereference NULL
@ 2016-05-18 20:59 Heinrich Schuchardt
2016-05-23 10:35 ` Eric Engestrom
0 siblings, 1 reply; 2+ messages in thread
From: Heinrich Schuchardt @ 2016-05-18 20:59 UTC (permalink / raw)
To: David Airlie, Matthias Brugger
Cc: Jie Qiu, Philipp Zabel, dri-devel, linux-arm-kernel,
linux-mediatek, linux-kernel, Heinrich Schuchardt
After having verified that dpi is NULL we should not
dereference it.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index d05ca79..3dbd00d 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -433,7 +433,7 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
unsigned int factor;
if (!dpi) {
- dev_err(dpi->dev, "invalid argument\n");
+ dev_err(NULL, "invalid argument\n");
return -EINVAL;
}
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] drm/mediatek: do not dereference NULL
2016-05-18 20:59 [PATCH 1/1] drm/mediatek: do not dereference NULL Heinrich Schuchardt
@ 2016-05-23 10:35 ` Eric Engestrom
0 siblings, 0 replies; 2+ messages in thread
From: Eric Engestrom @ 2016-05-23 10:35 UTC (permalink / raw)
To: Heinrich Schuchardt
Cc: David Airlie, Matthias Brugger, Jie Qiu, linux-kernel, dri-devel,
linux-mediatek, linux-arm-kernel
On Wed, May 18, 2016 at 10:59:50PM +0200, Heinrich Schuchardt wrote:
> After having verified that dpi is NULL we should not
> dereference it.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index d05ca79..3dbd00d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -433,7 +433,7 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
> unsigned int factor;
>
> if (!dpi) {
> - dev_err(dpi->dev, "invalid argument\n");
> + dev_err(NULL, "invalid argument\n");
> return -EINVAL;
> }
>
> --
> 2.1.4
Seems obvious ^^
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-23 10:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-18 20:59 [PATCH 1/1] drm/mediatek: do not dereference NULL Heinrich Schuchardt
2016-05-23 10:35 ` Eric Engestrom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox