From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753703AbcEWK52 (ORCPT ); Mon, 23 May 2016 06:57:28 -0400 Received: from mail-am1on0101.outbound.protection.outlook.com ([157.56.112.101]:16835 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752102AbcEWK50 (ORCPT ); Mon, 23 May 2016 06:57:26 -0400 Authentication-Results: linux-foundation.org; dkim=none (message not signed) header.d=none;linux-foundation.org; dmarc=none action=none header.from=virtuozzo.com; Date: Mon, 23 May 2016 13:57:18 +0300 From: Vladimir Davydov To: Andrew Morton CC: Alexander Viro , Johannes Weiner , Michal Hocko , , Subject: Re: [PATCH 7/8] pipe: account to kmemcg Message-ID: <20160523105718.GC7917@esperanza> References: <9e5dd7673dc37f198615b717fb1eae9309115134.1463997354.git.vdavydov@virtuozzo.com> <201605231850.3CoT8OXo%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <201605231850.3CoT8OXo%fengguang.wu@intel.com> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AMSPR02CA0031.eurprd02.prod.outlook.com (2a01:111:e400:8028::31) To AM3PR08MB0577.eurprd08.prod.outlook.com (2a01:111:e400:c408::11) X-MS-Office365-Filtering-Correlation-Id: efb52f77-eb91-4aef-bda0-08d382f90544 X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0577;2:/6wqomVH26n/pJ6Oii94wjeeNUuz0VwJFtusJn3kY9U8HGmYi3El7tHjP2TM9RNB7CTcMvGYRKgWYpPBCdKSX1Pbx+0lc1O6YwOVNv+WfnAacHJbaP8rxOr3SkMeTsaop/J3xax0uptCn38Fc1+d29tcFLnLGr2tkMq0zCnvrSGQKdLn0Fqz2n333wX0j6d4;3:spbHtybkiuPv+ZS21Am2x9Nhz4ZJ8jbmzCH95I51PhcjbSegRq+o5lo7Y1ZOn5o3g0IPngY0yl7K1MFNsZP85NtSwGXJnkfn6nq5mfw5XK7EnFZ0Lhv6qoOecduBYEVQ;25:/zqBmU03IZZO27PdyXdvh/xMSsZk/PgdH2G9GWMZ5/m5YEdOiVsd6HuGdQ4dwDhapMDYgu/99dz2Sy2gXfjqJrej3VvqNbuMNoLk3cv0vaP8QPoSMixJKbaGGzxh6LOHEcVEyJj3PQPPxodhGkog2VarsZZqxAcMjFeQ8L5C8DGQ+U0ZtIFqyhht308poWTJw9xEIlZBlBXSR3QaJDEvGDR2oJ515sahSxeZSec/UX8rm4a/sr9N3km0vSQ3R5z/5PxUjAzoicQFEgOdz7QmabzBEpkPOMgH2h0hQMOli06Ar4jSKrodlnNWkNP786sXA0hEW+SgtKAgIkeWD/sUFm4qfdPmTw76l1IiuL+l/3YL2Xnw8hBCCcauXoBTa/WIu7TrmZqMwx0moy1qQ+43d+Z8dGPBX1pEiq7NCqWiCeQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0577; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:AM3PR08MB0577;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0577; X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0577;4:d/ZVGnRwjwJCmyCnKpTkZRDRy2756rryROQCZFRzKId69/MyLgbwHpD45i5avXq6vTE/q0YH9PVvrdlk/23ELZFtESLfgmfQx0j4w5ioaqJRuoUoh76MQbmCIXKkjqoYBVyyRn8wtAx2XPoqDBT1AjEHiNiU1250YyYAfxUtyl1t6cQkIQE5P46qCBwWsYPnx2BZUpqPbL8uJUtNgf5iE6q5sdyZcpajI+osIsyqQW8SVtcfwIqd+k9JdAfhCrpno8oqxaEJT6pZol4Oy+rD1t0r0XsLqwNXA53NRTKN4v+evjrX93XqFzqe/6AjLs7vK0E7pXev0wrQN951hP67GfDWQo86vnxelVeId/ytKsIFTqOJPJqapVk1nud3wXtJ7bgShBjB4GNM3tk/K8JxRLWuK7eqOaU7vYRINB3kV3I= X-Forefront-PRVS: 0951AB0A30 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(24454002)(189998001)(42186005)(2950100001)(76176999)(54356999)(50986999)(9686002)(81166006)(8676002)(15650500001)(46406003)(50466002)(19580395003)(47776003)(86362001)(1076002)(586003)(4326007)(66066001)(3846002)(6116002)(2906002)(110136002)(19580405001)(23726003)(33716001)(97756001)(33656002)(80792005)(5008740100001)(92566002)(5004730100002)(575784001);DIR:OUT;SFP:1102;SCL:1;SRVR:AM3PR08MB0577;H:esperanza;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;AM3PR08MB0577;23:Hw2O67w3M0wKPEKxKFe3CI7XOhRc0+JwvD2sliHba?= =?us-ascii?Q?iJdowpPC/Nza2Aaj4xKX9TQkLXbc/a0JW9MGfrmymVPUipByZ6G7m8ZDahN8?= =?us-ascii?Q?PJm24Zl0WWkRsVsHC37dixsxLqKc9Eokf0fQBYcO0/FzZ0j3MnJPHMmmxRIT?= =?us-ascii?Q?qxzkfQsn1LY5XT/T06stwar4vX3EfhrTBDCv53Kvg17rS6+GWuc21XoRNhf7?= =?us-ascii?Q?3HK0e/91i9S4j5ctyknLob4+IvCZ3M6RxPdW4ZTtoBALSU27S5qLjT/FuPmB?= =?us-ascii?Q?KVGg5PeNO2LF3AyAt++BgUHswU874gpnTBoxVaDaEPPq1jCdRbn45f/lPxHU?= =?us-ascii?Q?x3ZpNhzUJ+FEBZmpqxefkU+tBRUgAavMsHmpTcs829kQdcqhBNZOqTZUKLM2?= =?us-ascii?Q?bVaDxe0o0dI7r68tfsXGhoR37Vdq++BVFfBJWyyKf7oHRWfqPrXNzeZXc2Ug?= =?us-ascii?Q?1UUaUSlmxtGMtmq79PPtYgjikTJcVYagi0Klibg2L/MzEfEszFYQFQAOxzIH?= =?us-ascii?Q?5XfRlVHCDV53b3KDNQTNmo4Jc8+yp6f/0FtG6VpCcUfJRRJwIQBQk5cZdr6m?= =?us-ascii?Q?UHlJioF3/IQWvLcEDeHs/lKnC8XRJN5C9PxEQeLBSN1+A2rlnOwDf29eKbyj?= =?us-ascii?Q?G9Tb99+Umw1kIwc0Gs7wejjd6vetQ1xm2CQmiywobnz9NWrSjYzp7Hj4JHIP?= =?us-ascii?Q?Ws4odJpsPbb5RNbHdsbgL0Y4R2RZ+gcMISkMAQxvo9OewtEWnx+C0NtaiOQp?= =?us-ascii?Q?eYHWjQu7T4MZqag/HU6Lj41eVuN8fCEK+mKHfFX5E56xxNqxGKd/k1pPW2c5?= =?us-ascii?Q?dEbCqibTQEbfpofIgam+SVq3wBSMkhb6370LCpBLst9caPbNq1/kufTwwZfe?= =?us-ascii?Q?v1+yGP2jy7JJwEYG5G+uQlUKpaBdv+4udJa69l0LSFgMCYGBeKkeZ+3wNk2k?= =?us-ascii?Q?yZSU/PnK8fkWymlILhdLOla1sHfmq8n4zeDBN5fWg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR08MB0577;5:s1XdKZzNvHDnGJDpzv7dcdIXq+tC7u+o5ojiC99eHSciYgAebmVsSYVaIkEKLZSVLOVuHO6tB6UduxrC4LVcaL+gaidUXy7FDGgcwCbtKE3Ag6bX8xSrVK1qIYXa5FGbvrJOD/QwVfWQGbiSTSxa3A==;24:Nx6JROlvFoYQwP+FMhScz0Rrr/gy1EkCHWLA/rJ/5lScI7h5Rxzm6yJwY7YCV3lNZ+GPmo7aymsSfZuuveVZacm21jZOmpyEvuF9vco/AUU=;7:fSx+oDIQTcY/KzN5/qx2Hi2lHoFk3jCAi9dg/V0L0IOdfpfoBY/12cqNw8IQpQwFpvk/uz6lEdob6FUlgAalmkG9d7yKqQB08jbrJxehnMpo2fI5Ng+CBEUefQVTQWfI50gbGLkZN9hwsWhSjEb7Ii66TBCpt25Ox2TRoyjwyT6uHdXTxwjAnI7hSP+qoiL4;20:kCoLCPrGaye/DmoZ1PKknH1AosLhcerLwt5kaNwTlqYofsKeRiOciG2dhYz850FZ63aty+2/Uqts0igG+qqxodlyLfROK3HtFmlvw0FE5ayjMDOGlcYHO1/m9dbrymoiSkWceUFGsii3sXU3esR93ONk9aB8Pkgot/8zi4KYO50= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2016 10:57:23.0449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0577 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2016 at 06:39:40PM +0800, kbuild test robot wrote: ... > fs/built-in.o: In function `anon_pipe_buf_steal': > >> pipe.c:(.text+0x5f8d): undefined reference to `memcg_kmem_uncharge' From: Vladimir Davydov Subject: [PATCH] pipe-account-to-kmemcg-fix diff --git a/fs/pipe.c b/fs/pipe.c index 6345f3543788..b3ad0b33f04e 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -144,8 +144,10 @@ static int anon_pipe_buf_steal(struct pipe_inode_info *pipe, struct page *page = buf->page; if (page_count(page) == 1) { - memcg_kmem_uncharge(page, 0); - __ClearPageKmemcg(page); + if (memcg_kmem_enabled()) { + memcg_kmem_uncharge(page, 0); + __ClearPageKmemcg(page); + } __SetPageLocked(page); return 0; }