From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754777AbcEWUcs (ORCPT ); Mon, 23 May 2016 16:32:48 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:34186 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbcEWUcp (ORCPT ); Mon, 23 May 2016 16:32:45 -0400 Date: Mon, 23 May 2016 13:32:39 -0700 From: Brian Norris To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet , Li Zefan Subject: Re: [PATCH] doc: clarify that trace_events= takes a comma-separated list Message-ID: <20160523203239.GA28530@google.com> References: <1464034111-25340-1-git-send-email-computersforpeace@gmail.com> <20160523162544.47d31291@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160523162544.47d31291@gandalf.local.home> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2016 at 04:25:44PM -0400, Steven Rostedt wrote: > On Mon, 23 May 2016 13:08:31 -0700 > Brian Norris wrote: > > > It took me browsing through the source code to determine that I was, > > indeed, using the wrong delimiter in my command lines. So I might as > > well document it for the next person. > > > > Signed-off-by: Brian Norris > > --- > > Documentation/kernel-parameters.txt | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt > > index 5349363b603c..594bf50b8f81 100644 > > --- a/Documentation/kernel-parameters.txt > > +++ b/Documentation/kernel-parameters.txt > > @@ -3994,7 +3994,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted. > > > > trace_event=[event-list] > > [FTRACE] Set and start specified trace events in order > > - to facilitate early boot debugging. > > + to facilitate early boot debugging. The event-list is a > > + comma separated list of trace events to enable, as if > > + you were to append the event(s) to > > + > > + /sys/kernel/debug/tracing/set_event > > + > > I agree that we should document that the list is comma separated, but > the wording you have above, makes it sound like the set_event file > also takes a comma separated list, which it does not. That file > requires a space separated list. Hmm, good point. I added the latter half of the sentence at the last moment, so I didn't give that part as good of a read. > Can you reword that so that it removes the confusion. Thanks! Sure, I'll try. Would it be OK if I just dropped the latter part of the sentence, and didn't mention /sys/.../set_event at all? Like: "The event-list is a comma separated list of trace events to enable. See also Documentation/trace/events.txt" Brian