From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752141AbcEWVZF (ORCPT <rfc822;w@1wt.eu>);
	Mon, 23 May 2016 17:25:05 -0400
Received: from mail.kernel.org ([198.145.29.136]:55338 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751789AbcEWVZB (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 23 May 2016 17:25:01 -0400
Date: Mon, 23 May 2016 18:24:55 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: pi3orama@163.com, linux-kernel@vger.kernel.org,
        He Kuang <hekuang@huawei.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
        Namhyung Kim <namhyung@kernel.org>, Zefan Li <lizefan@huawei.com>
Subject: Re: [PATCH v3 01/11] perf tools: Add API to pause/resume a evlist
Message-ID: <20160523212455.GM8897@kernel.org>
References: <1463987628-163563-1-git-send-email-wangnan0@huawei.com>
 <1463987628-163563-2-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1463987628-163563-2-git-send-email-wangnan0@huawei.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Mon, May 23, 2016 at 07:13:38AM +0000, Wang Nan escreveu:
> +++ b/tools/perf/util/evlist.c
> @@ -679,6 +679,38 @@ static struct perf_evsel *perf_evlist__event2evsel(struct perf_evlist *evlist,
>  	return NULL;
>  }
>  
> +static int perf_evlist__set_paused(struct perf_evlist *evlist, bool pause)
> +{
> +	int i;
> +
> +	for (i = 0; i < evlist->nr_mmaps; i++) {
> +		int fd = evlist->mmap[i].fd;
> +		int err;
> +
> +		if (fd < 0)
> +			continue;
> +		err = ioctl(fd, PERF_EVENT_IOC_PAUSE_OUTPUT,
> +			    pause ? 1 : 0);
> +		if (err) {
> +			err = (errno == 0 ? -EINVAL : -errno);
> +			pr_err("Unable to pause output on %d: %s\n",
> +			       fd, strerror(-err));

I changed this to:
		if (err)
			return err;

Like all other ioctl wrappers in evlist.c, i.e. usage model is the same
as with 'ioctl()': -1 indicates that it failed, if code using this
function wants to know more about the reason for the error, check errno.

Ah, we can't use 'pause' as a parameter name, that breaks the build on
Ubuntu 12.04 and other old glibc headers, I fixed that as well.

- Arnaldo

> +			return err;
> +		}
> +	}
> +	return 0;