From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "Usyskin, Alexander" <alexander.usyskin@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl
Date: Mon, 23 May 2016 14:28:13 -0700 [thread overview]
Message-ID: <20160523212813.GD11415@kroah.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B5426FC8E@hasmsx108.ger.corp.intel.com>
On Mon, May 23, 2016 at 01:07:53PM +0000, Winkler, Tomas wrote:
> >
> > From: Alexander Usyskin <alexander.usyskin@intel.com>
> >
> > wr_ctrl waiters are none interruptible, so should be waken up with call to
> > wake_up and not to wake_up_interruptible.
> >
> > This fixes commit:
> > 7ff4bdd ("mei: fix waiting for wr_ctrl for corner cases.")
> >
> > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
>
> Hi Greg,
> I see this fix didn't make it to rc1, so currently the driver is somehow broken.
> Can you please make an effort and include the fix in next rc?
Ugh, didn't realize it was totally broken, the patch didn't really say
that, sorry. I'll queue it up once 4.7-rc1 is out.
thanks,
greg k-h
next prev parent reply other threads:[~2016-05-23 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 4:07 [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl Tomas Winkler
2016-05-09 4:07 ` [char-misc-next 2/2] mei: drop wr_msg from the mei_dev structure Tomas Winkler
2016-05-23 13:07 ` [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl Winkler, Tomas
2016-05-23 21:28 ` Greg Kroah-Hartman [this message]
2016-05-24 8:50 ` Winkler, Tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160523212813.GD11415@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.usyskin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox