From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752103AbcEWV2P (ORCPT ); Mon, 23 May 2016 17:28:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40995 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346AbcEWV2O (ORCPT ); Mon, 23 May 2016 17:28:14 -0400 Date: Mon, 23 May 2016 14:28:13 -0700 From: Greg Kroah-Hartman To: "Winkler, Tomas" Cc: "Usyskin, Alexander" , "linux-kernel@vger.kernel.org" Subject: Re: [char-misc-next 1/2] mei: don't use wake_up_interruptible for wr_ctrl Message-ID: <20160523212813.GD11415@kroah.com> References: <1462766867-27248-1-git-send-email-tomas.winkler@intel.com> <5B8DA87D05A7694D9FA63FD143655C1B5426FC8E@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B5426FC8E@hasmsx108.ger.corp.intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2016 at 01:07:53PM +0000, Winkler, Tomas wrote: > > > > From: Alexander Usyskin > > > > wr_ctrl waiters are none interruptible, so should be waken up with call to > > wake_up and not to wake_up_interruptible. > > > > This fixes commit: > > 7ff4bdd ("mei: fix waiting for wr_ctrl for corner cases.") > > > > Signed-off-by: Alexander Usyskin > > Signed-off-by: Tomas Winkler > > Hi Greg, > I see this fix didn't make it to rc1, so currently the driver is somehow broken. > Can you please make an effort and include the fix in next rc? Ugh, didn't realize it was totally broken, the patch didn't really say that, sorry. I'll queue it up once 4.7-rc1 is out. thanks, greg k-h