From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753485AbcEXAuw (ORCPT ); Mon, 23 May 2016 20:50:52 -0400 Received: from mga09.intel.com ([134.134.136.24]:12418 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbcEXAuv (ORCPT ); Mon, 23 May 2016 20:50:51 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,358,1459839600"; d="scan'208";a="960855731" Date: Mon, 23 May 2016 17:50:49 -0700 From: Andi Kleen To: Adrian Hunter Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] perf pt: Mark PT return events as "return" Message-ID: <20160524005049.GA22049@tassilo.jf.intel.com> References: <1463773938-26194-1-git-send-email-andi@firstfloor.org> <5742F1F4.9040709@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5742F1F4.9040709@intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2016 at 03:05:08PM +0300, Adrian Hunter wrote: > On 20/05/16 22:52, Andi Kleen wrote: > > From: Andi Kleen > > > > With perf script --itrace=cr we can synthesize calls and returns out of > > a PT log. However both calls and returns are marked with the same event, > > called branches. This makes it difficult to read and post process, > > because calls and returns are somewhat diffferent. > > Did you consider the sample flags? > e.g. True. But reporting it in the event name looks nicer, so I think the patch is still useful. -Andi -- ak@linux.intel.com -- Speaking for myself only