From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754877AbcEXIyU (ORCPT ); Tue, 24 May 2016 04:54:20 -0400 Received: from e17.ny.us.ibm.com ([129.33.205.207]:54385 "EHLO e17.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752666AbcEXIyR (ORCPT ); Tue, 24 May 2016 04:54:17 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: ego@linux.vnet.ibm.com X-IBM-RcptTo: mpe@ellerman.id.au;linuxppc-dev@lists.ozlabs.org;mikey@neuling.org;paulus@ozlabs.org;linux-kernel@vger.kernel.org Date: Tue, 24 May 2016 14:24:06 +0530 From: Gautham R Shenoy To: "Shreyas B. Prabhu" Cc: mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, paulus@ozlabs.org, linux-kernel@vger.kernel.org, mikey@neuling.org, ego@linux.vnet.ibm.com Subject: Re: [PATCH v3 4/9] powerpc/powernv: Make power7_powersave_common more generic Message-ID: <20160524085406.GC12860@in.ibm.com> Reply-To: ego@linux.vnet.ibm.com References: <1464016722-7488-1-git-send-email-shreyas@linux.vnet.ibm.com> <1464016722-7488-5-git-send-email-shreyas@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1464016722-7488-5-git-send-email-shreyas@linux.vnet.ibm.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16052408-0041-0000-0000-00000438F5E5 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Shreyas, On Mon, May 23, 2016 at 08:48:37PM +0530, Shreyas B. Prabhu wrote: > power7_powersave_common does common steps needed before entering idle > state and eventually changes MSR to MSR_IDLE and does rfid to > power7_enter_nap_mode. > > Move the updation of HSTATE_HWTHREAD_STATE to power7_powersave_common > from power7_enter_nap_mode and make it more generic by passing the rfid > address as a function parameter. > > Also make function name more generic. > > Reviewed-by: Gautham R. Shenoy > Signed-off-by: Shreyas B. Prabhu > --- > Changes in v3: > ============== > - Moved HSTATE_HWTHREAD_STATE updation to power_powersave_common > > arch/powerpc/kernel/idle_power_common.S | 30 +++++++++++++++++------------- > 1 file changed, 17 insertions(+), 13 deletions(-) > > diff --git a/arch/powerpc/kernel/idle_power_common.S b/arch/powerpc/kernel/idle_power_common.S > index 973c9a1..d100577 100644 > --- a/arch/powerpc/kernel/idle_power_common.S > +++ b/arch/powerpc/kernel/idle_power_common.S > @@ -74,8 +74,10 @@ core_idle_lock_held: > * To check IRQ_HAPPENED in r4 > * 0 - don't check > * 1 - check > + * > + * Address to 'rfid' to in r5 > */ > -_GLOBAL(power7_powersave_common) > +_GLOBAL(pnv_powersave_common) You can move this rename to the previous patch where it fits better. [..snip..] > > .globl power7_enter_nap_mode > power7_enter_nap_mode: Ditto. This should be "pnv_enter_idle_mode" in the previous patch. [..snip..] > > _GLOBAL(power7_winkle) > li r3,3 li r3,PNV_THREAD_WINKLE Which should be a separate patch.